Issue 769073003: skia: Prevent GL_RED from being used with MESA

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 769073003: skia: Prevent GL_RED from being used with MESA (Closed)

Created:
6 years ago by hendrikw

Modified:
6 years ago

Reviewers:
bsalomon

CC:
reviews_skia.org

Base URL:
https://chromium.googlesource.com/skia.git@master

Project:
skia

Visibility:
Public.

skia: Prevent GL_RED from being used with MESA MESA unfortunately doesn't support GL_RED or GL_RG when used with frame buffers. Don't allow fTextureRedSupport to be set when using MESA. BUG=skia:3181 Committed: https://skia.googlesource.com/skia/+/a0d5ad7208d579e3a9f7a680cbbaf0d2ae5c5d71

Created: 6 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -10 lines)			Patch
	M	src/gpu/gl/GrGLCaps.cpp	View		1 chunk	+7 lines, -10 lines	0 comments	Download

Total messages: 6 (2 generated)

hendrikw

Hi, here's a fix for MESA+texture_rg in skia. This doesn't affect my change so if ...

6 years ago (2014-12-02 00:31:02 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/769073003/1

6 years ago (2014-12-02 15:20:56 UTC) #5

commit-bot: I haz the power

6 years ago (2014-12-02 15:30:33 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/a0d5ad7208d579e3a9f7a680cbbaf0d2ae5c5d71