Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1189)

Issue 768973003: Cleanup: Get rid of base::ASCIIToWide(). (Closed)

Created:
6 years ago by Lei Zhang
Modified:
6 years ago
CC:
chromium-reviews, erikwright+watch_chromium.org, jshin+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Cleanup: Get rid of base::ASCIIToWide(). BUG=23581 Committed: https://crrev.com/93570e26b8f852041f5729fe40f53361ee1e6b49 Cr-Commit-Position: refs/heads/master@{#307333}

Patch Set 1 #

Patch Set 2 : fix build #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -63 lines) Patch
M base/strings/string_util_unittest.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M base/strings/utf_string_conversions.h View 1 chunk +2 lines, -3 lines 0 comments Download
M base/strings/utf_string_conversions.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M rlz/win/lib/machine_deal.cc View 1 3 chunks +4 lines, -4 lines 0 comments Download
M rlz/win/lib/registry_util.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M rlz/win/lib/registry_util.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M rlz/win/lib/rlz_value_store_registry.cc View 14 chunks +34 lines, -41 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Lei Zhang
6 years ago (2014-12-06 01:57:09 UTC) #2
Roger Tawa OOO till Jul 10th
lgtm
6 years ago (2014-12-08 16:07:18 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/768973003/20001
6 years ago (2014-12-08 19:46:30 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years ago (2014-12-08 21:00:29 UTC) #6
commit-bot: I haz the power
6 years ago (2014-12-08 21:01:14 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/93570e26b8f852041f5729fe40f53361ee1e6b49
Cr-Commit-Position: refs/heads/master@{#307333}

Powered by Google App Engine
This is Rietveld 408576698