Issue 7689002: Remove obsolete kForceCompactionMask flag for GC.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7689002: Remove obsolete kForceCompactionMask flag for GC. (Closed)

Created:
9 years, 4 months ago by Michael Starzinger

Modified:
9 years, 4 months ago

Reviewers:
Vyacheslav Egorov (Chromium)

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/experimental/gc

Visibility:
Public.

Description

Remove obsolete kForceCompactionMask flag for GC. R=vegorov@chromium.org BUG=v8:1608 Committed: http://code.google.com/p/v8/source/detail?r=9015

Patch Set 2 : Do meaningful work on LowMemoryNotification. #

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+46 lines, -62 lines)			Patch
M	src/api.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/extensions/gc-extension.cc	View		1 chunk	+1 line, -6 lines	0 comments	Download
M	src/heap.h	View	1	2 chunks	+7 lines, -9 lines	0 comments	Download
M	src/heap.cc	View	1	3 chunks	+2 lines, -4 lines	0 comments	Download
M	test/cctest/test-accessors.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	test/cctest/test-api.cc	View	1	3 chunks	+3 lines, -3 lines	0 comments	Download
M	test/cctest/test-debug.cc	View		9 chunks	+10 lines, -17 lines	0 comments	Download
M	test/cctest/test-heap.cc	View		7 chunks	+16 lines, -16 lines	0 comments	Download
M	test/cctest/test-heap-profiler.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	test/cctest/test-serialize.cc	View		2 chunks	+3 lines, -3 lines	0 comments	Download
M	test/mjsunit/regress/regress-deopt-gc.js	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Vyacheslav Egorov (Chromium)

LGTM http://codereview.chromium.org/7689002/diff/1/src/api.cc File src/api.cc (right): http://codereview.chromium.org/7689002/diff/1/src/api.cc#newcode3972 src/api.cc:3972: isolate->heap()->CollectAllGarbage(i::Heap::kNoGCFlags); Please file an issue to do meaningful ...

9 years, 4 months ago (2011-08-19 12:45:51 UTC) #2

Michael Starzinger

9 years, 4 months ago (2011-08-19 13:07:06 UTC) #3

On 2011/08/19 12:45:51, Vyacheslav Egorov wrote:
> http://codereview.chromium.org/7689002/diff/1/src/api.cc#newcode3972
> src/api.cc:3972: isolate->heap()->CollectAllGarbage(i::Heap::kNoGCFlags);
> Please file an issue to do meaningful work on LowMemoryNotification.

Wouldn't a call to Heap::CollectAllAvailableGarbage() be the most meaningful
thing to do in this case?

Expand Messages | Collapse Messages

Issue 7689002: Remove obsolete kForceCompactionMask flag for GC. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Do meaningful work on LowMemoryNotification. #

Messages