Issue 768893002: Remove border-collapse

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 768893002: Remove border-collapse (Closed)

Created:
6 years ago by rafaelw

Modified:
6 years ago

Reviewers:
ojan

CC:
ojan, abarth-chromium, esprehn, mojo-reviews_chromium.org

Base URL:
https://github.com/domokit/mojo.git@master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Remove border-collapse R=ojan@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/d1c057fab51566b3145e4fdbe809402b2b7cda3c

Patch Set 1 #

Total comments: 1

Created: 6 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+0 lines, -48 lines)			Patch
M	sky/engine/core/css/CSSComputedStyleDeclaration.cpp	View	2 chunks	+0 lines, -5 lines	0 comments	Download
M	sky/engine/core/css/CSSPrimitiveValueMappings.h	View	1 chunk	+0 lines, -31 lines	0 comments	Download
M	sky/engine/core/css/CSSProperties.in	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	sky/engine/core/css/parser/BisonCSSParser-in.cpp	View	2 chunks	+0 lines, -3 lines	0 comments	Download
M	sky/engine/core/rendering/style/RenderStyle.h	View	6 chunks	+0 lines, -6 lines	1 comment	Download
M	sky/engine/core/rendering/style/RenderStyleConstants.h	View	1 chunk	+0 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

ojan

lgtm https://codereview.chromium.org/768893002/diff/1/sky/engine/core/rendering/style/RenderStyle.h File sky/engine/core/rendering/style/RenderStyle.h (right): https://codereview.chromium.org/768893002/diff/1/sky/engine/core/rendering/style/RenderStyle.h#newcode253 sky/engine/core/rendering/style/RenderStyle.h:253: inherited_flags.m_printColorAdjust = initialPrintColorAdjust(); If you're looking for more ...

6 years ago (2014-11-28 22:29:13 UTC) #3

rafaelw

6 years ago (2014-11-28 22:33:31 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
d1c057fab51566b3145e4fdbe809402b2b7cda3c (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages