Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(299)

Issue 768883004: Nukes view_manager_unittests (Closed)

Created:
6 years ago by sky
Modified:
6 years ago
Reviewers:
viettrungluu
CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Project:
mojo
Visibility:
Public.

Description

Nukes view_manager_unittests I converted them over to apptests a while back. Now that we're running the apptests I can nuke this outdated test. BUG=none TEST=none R=viettrungluu@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/839a1b29cebad3b39b0236883fc7324d44a9e48f

Patch Set 1 #

Patch Set 2 : merge to trunk #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1659 lines) Patch
M mojo/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M mojo/tools/data/unittests View 1 1 chunk +0 lines, -1 line 0 comments Download
M services/view_manager/BUILD.gn View 1 chunk +0 lines, -33 lines 0 comments Download
D services/view_manager/view_manager_unittest.cc View 1 chunk +0 lines, -1624 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
sky
6 years ago (2014-12-03 03:11:34 UTC) #1
viettrungluu
OK, LGTM (assuming you can get it to be green on the bots).
6 years ago (2014-12-03 16:25:03 UTC) #2
sky
6 years ago (2014-12-03 18:22:55 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
839a1b29cebad3b39b0236883fc7324d44a9e48f (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698