Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1058)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 768833002: Stage @@toStringTag (--harmony-tostring) (Closed)

Created:
6 years ago by Dmitry Lomov (no reviews)
Modified:
6 years ago
Reviewers:
caitp (gmail), rossberg
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Project:
v8
Visibility:
Public.

Description

Stage @@toStringTag (--harmony-tostring) R=rossberg@chromium.org,caitpotter88@gmail.com LOG=Y

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M src/flag-definitions.h View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
Dmitry Lomov (no reviews)
PTAL. Yell if you know there is something undone.
6 years ago (2014-11-28 14:48:40 UTC) #1
rossberg
lgtm
6 years ago (2014-11-28 14:57:45 UTC) #2
Dmitry Lomov (no reviews)
On 2014/11/28 14:57:45, rossberg wrote: > lgtm Thanks! Caitlin, not landing unless you approve as ...
6 years ago (2014-11-28 14:59:16 UTC) #3
caitp (gmail)
On 2014/11/28 14:59:16, Dmitry Lomov (chromium) wrote: > On 2014/11/28 14:57:45, rossberg wrote: > > ...
6 years ago (2014-11-28 15:03:36 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/768833002/1
6 years ago (2014-11-28 15:12:32 UTC) #6
commit-bot: I haz the power
6 years ago (2014-11-28 15:41:42 UTC) #7
Message was sent while issue was closed. 
Committed patchset #1 (id:1)

Powered by Google App Engine
This is Rietveld 408576698