Source/core/loader/MixedContentChecker.cpp - Issue 768753003: Downgrade the security of a secured page when plugins make insecure calls

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/loader/MixedContentChecker.cpp

Issue 768753003: Downgrade the security of a secured page when plugins make insecure calls (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Layout test for prefetching from insecure source added Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/loader/MixedContentChecker.cpp

diff --git a/Source/core/loader/MixedContentChecker.cpp b/Source/core/loader/MixedContentChecker.cpp

index a95506608316f069b44f0143160f2e87ba232705..c5ebb0de645d5b71b8de8256b30523456a4f2451 100644

--- a/Source/core/loader/MixedContentChecker.cpp

+++ b/Source/core/loader/MixedContentChecker.cpp

@@ -272,7 +272,9 @@ bool MixedContentChecker::shouldBlockFetch(LocalFrame* frame, const ResourceRequ

break;

case ContextTypeShouldBeBlockable:

- return false;

+ allowed = true;

+ client->didDisplayInsecureContent();

+ break;

case ContextTypeBlockableUnlessLax:

// We map this to either OptionallyBlockable or Blockable above.

« no previous file with comments | « LayoutTests/http/tests/security/mixedContent/insecure-prefetch-in-main-frame-expected.txt ('k') | no next file » | no next file with comments »