Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(252)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 768683006: convert compile-time checkable DCHECKs to STATIC_ASSERTs (Closed)

Created:
6 years ago by Mostyn Bramley-Moore
Modified:
5 years, 11 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

convert compile-time checkable DCHECKs to STATIC_ASSERTs Committed: https://crrev.com/cc6c373e2a25ae5ab54ea0ff042230364ec1a21b Cr-Commit-Position: refs/heads/master@{#26187}

Patch Set 1 #

Patch Set 2 : staticify another DCHECK #

Patch Set 3 : rebase on master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M src/arm/code-stubs-arm.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/code-stubs-hydrogen.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 16 (7 generated)
Mostyn Bramley-Moore
@mvstanton, Toon: please take a look at this tiny followup to https://codereview.chromium.org/546683003 Alternatively it might ...
6 years ago (2014-12-08 21:46:40 UTC) #2
Toon Verwaest
lgtm
5 years, 11 months ago (2015-01-21 10:42:09 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/768683006/20001
5 years, 11 months ago (2015-01-21 10:43:11 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: v8_mac_rel on tryserver.v8 (http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel/builds/2416)
5 years, 11 months ago (2015-01-21 10:47:55 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/768683006/40001
5 years, 11 months ago (2015-01-21 12:04:25 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_arm_rel on tryserver.v8 (http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm_rel/builds/839)
5 years, 11 months ago (2015-01-21 12:45:11 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/768683006/40001
5 years, 11 months ago (2015-01-21 13:07:36 UTC) #14
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 11 months ago (2015-01-21 13:38:12 UTC) #15
commit-bot: I haz the power
5 years, 11 months ago (2015-01-21 13:38:32 UTC) #16
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/cc6c373e2a25ae5ab54ea0ff042230364ec1a21b
Cr-Commit-Position: refs/heads/master@{#26187}

Powered by Google App Engine
This is Rietveld 408576698