Issue 768683003: Switch clipboard_unittests to clipboard_apptests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 768683003: Switch clipboard_unittests to clipboard_apptests. (Closed)

Created:
6 years ago by Elliot Glaysher

Modified:
6 years ago

Reviewers:
msw

CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org

Base URL:
https://github.com/domokit/mojo.git@master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Switch clipboard_unittests to clipboard_apptests. BUG=none R=msw@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/9fb185d7dbdd343925cb01c9923deefaf43c801c

Patch Set 1 #

Patch Set 2 : Rename the class #

Total comments: 2

Patch Set 3 : oneliners #

Created: 6 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+26 lines, -197 lines)			Patch
M	mojo/BUILD.gn	View		1 chunk	+1 line, -1 line	0 comments	Download
M	mojo/tools/data/apptests	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	mojo/tools/data/unittests	View		1 chunk	+0 lines, -3 lines	0 comments	Download
M	services/clipboard/BUILD.gn	View	1 2	1 chunk	+11 lines, -12 lines	0 comments	Download
A +	services/clipboard/clipboard_apptest.cc	View	1	5 chunks	+13 lines, -19 lines	0 comments	Download
D	services/clipboard/clipboard_standalone_unittest.cc	View		1 chunk	+0 lines, -162 lines	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

msw

Nice, did you test that these run okay with "mojo/tools/mojob.py test"? If so, LGTM with ...

6 years ago (2014-12-04 22:20:22 UTC) #3

Elliot Glaysher

6 years ago (2014-12-04 22:38:02 UTC) #4

Message was sent while issue was closed.

Committed patchset #3 (id:40001) manually as
9fb185d7dbdd343925cb01c9923deefaf43c801c (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages