Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3204)

Unified Diff: chrome/browser/ui/status_bubble.h

Issue 7686015: ui: Pass the parameter |languages| of StatusBubble::SetURL() as std::string. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix mac Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/status_bubble.h
diff --git a/chrome/browser/ui/status_bubble.h b/chrome/browser/ui/status_bubble.h
index 43a30d2ba840eda6dc05af5fd7f52b409233f99c..2050dc9a883be1c5193a438e8def4d84e0eb4bdf 100644
--- a/chrome/browser/ui/status_bubble.h
+++ b/chrome/browser/ui/status_bubble.h
@@ -1,11 +1,13 @@
-// Copyright (c) 2010 The Chromium Authors. All rights reserved.
+// Copyright (c) 2011 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#ifndef CHROME_BROWSER_STATUS_BUBBLE_H_
-#define CHROME_BROWSER_STATUS_BUBBLE_H_
+#ifndef CHROME_BROWSER_UI_STATUS_BUBBLE_H_
+#define CHROME_BROWSER_UI_STATUS_BUBBLE_H_
#pragma once
+#include <string>
+
#include "base/string16.h"
class GURL;
@@ -36,9 +38,7 @@ class StatusBubble {
// the bubble to fade in and remain open until given an empty URL or until
// the Hide() method is called. languages is the value of Accept-Language
// to determine what characters are understood by a user.
- // TODO(tc): |languages| should be std::string (ascii)-- it's current
- // usage is as bad as a WideToUTF8Hack.
- virtual void SetURL(const GURL& url, const string16& languages) = 0;
+ virtual void SetURL(const GURL& url, const std::string& languages) = 0;
// Skip the fade and instant-hide the bubble.
virtual void Hide() = 0;
@@ -57,4 +57,4 @@ class StatusBubble {
virtual void UpdateDownloadShelfVisibility(bool visible) = 0;
};
-#endif // CHROME_BROWSER_STATUS_BUBBLE_H_
+#endif // CHROME_BROWSER_UI_STATUS_BUBBLE_H_

Powered by Google App Engine
This is Rietveld 408576698