chrome/browser/ui/cocoa/status_bubble_mac.h - Issue 7686015: ui: Pass the parameter |languages| of StatusBubble::SetURL() as std::string.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/status_bubble_mac.h

Issue 7686015: ui: Pass the parameter |languages| of StatusBubble::SetURL() as std::string. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: fix mac Created 9 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/cocoa/status_bubble_mac.h

diff --git a/chrome/browser/ui/cocoa/status_bubble_mac.h b/chrome/browser/ui/cocoa/status_bubble_mac.h

index 861e84109faf1ff2408506480010abec5f661873..70de27ea7901e1fae3a32d8c1ac0533eb1ee19fa 100644

--- a/chrome/browser/ui/cocoa/status_bubble_mac.h

+++ b/chrome/browser/ui/cocoa/status_bubble_mac.h

@@ -37,7 +37,7 @@ class StatusBubbleMac : public StatusBubble {

// StatusBubble implementation.

virtual void SetStatus(const string16& status);

tony 2011/08/22 16:31:02 While you're here, can you add OVERRIDE to these v

tfarina 2011/08/22 17:08:25 Done.

- virtual void SetURL(const GURL& url, const string16& languages);

+ virtual void SetURL(const GURL& url, const std::string& languages);

virtual void Hide();

virtual void MouseMoved(const gfx::Point& location, bool left_content);

virtual void UpdateDownloadShelfVisibility(bool visible);

@@ -174,7 +174,7 @@ class StatusBubbleMac : public StatusBubble {

// Needs to be passed to ElideURL if the original URL string is wider than

// the standard bubble width.

- string16 languages_;

+ std::string languages_;

DISALLOW_COPY_AND_ASSIGN(StatusBubbleMac);

};

« no previous file with comments | « chrome/browser/ui/browser.cc ('k') | chrome/browser/ui/cocoa/status_bubble_mac.mm » ('j') | chrome/browser/ui/gtk/status_bubble_gtk.h » ('J')