Issue 7686015: ui: Pass the parameter |languages| of StatusBubble::SetURL() as std::string.

Issue 7686015: ui: Pass the parameter |languages| of StatusBubble::SetURL() as std::string. (Closed)

Created:
9 years, 4 months ago by tfarina

Modified:
9 years, 4 months ago

Reviewers:
tony

CC:
chromium-reviews, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

ui: Pass the parameter |languages| of StatusBubble::SetURL() as std::string. Note: This was a TODO for tony. BUG=None TEST=None R=tony@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=97701

Patch Set 4 : add OVERRIDE #

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+64 lines, -63 lines)			Patch
M	chrome/browser/ui/browser.cc	View		3 chunks	+3 lines, -4 lines	0 comments	Download
M	chrome/browser/ui/cocoa/status_bubble_mac.h	View	1 2 3	3 chunks	+8 lines, -7 lines	0 comments	Download
M	chrome/browser/ui/cocoa/status_bubble_mac.mm	View	1 2	3 chunks	+5 lines, -6 lines	0 comments	Download
M	chrome/browser/ui/cocoa/status_bubble_mac_unittest.mm	View		7 chunks	+15 lines, -15 lines	0 comments	Download
M	chrome/browser/ui/gtk/status_bubble_gtk.h	View	1 2 3	4 chunks	+10 lines, -8 lines	0 comments	Download
M	chrome/browser/ui/gtk/status_bubble_gtk.cc	View		2 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/ui/status_bubble.h	View		3 chunks	+7 lines, -7 lines	0 comments	Download
M	chrome/browser/ui/views/status_bubble_views.h	View	1 2 3	4 chunks	+8 lines, -7 lines	0 comments	Download
M	chrome/browser/ui/views/status_bubble_views.cc	View	1	3 chunks	+5 lines, -6 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

tony

LGTM with the following changes. http://codereview.chromium.org/7686015/diff/4001/chrome/browser/ui/cocoa/status_bubble_mac.h File chrome/browser/ui/cocoa/status_bubble_mac.h (right): http://codereview.chromium.org/7686015/diff/4001/chrome/browser/ui/cocoa/status_bubble_mac.h#newcode39 chrome/browser/ui/cocoa/status_bubble_mac.h:39: virtual void SetStatus(const string16& ...

9 years, 4 months ago (2011-08-22 16:31:02 UTC) #2

tfarina

http://codereview.chromium.org/7686015/diff/4001/chrome/browser/ui/cocoa/status_bubble_mac.h File chrome/browser/ui/cocoa/status_bubble_mac.h (right): http://codereview.chromium.org/7686015/diff/4001/chrome/browser/ui/cocoa/status_bubble_mac.h#newcode39 chrome/browser/ui/cocoa/status_bubble_mac.h:39: virtual void SetStatus(const string16& status); On 2011/08/22 16:31:02, tony ...

9 years, 4 months ago (2011-08-22 17:08:25 UTC) #3

LGTM!

Expand Messages | Collapse Messages