[WIP] TrapHandler 2014/11/27.

src/compiler/simplified-operator-reducer.cc

 // Copyright 2014 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/compiler/generic-node-inl.h"
 #include "src/compiler/js-graph.h"
 #include "src/compiler/machine-operator.h"
 #include "src/compiler/node-matchers.h"
 #include "src/compiler/simplified-operator-reducer.h"
 
@@ skipping 81 matching lines @@
                       m.node()->InputAt(0));
       }
       if (m.IsChangeUint32ToTagged()) return Replace(m.node()->InputAt(0));
       break;
     }
     case IrOpcode::kChangeUint32ToTagged: {
       Uint32Matcher m(node->InputAt(0));
       if (m.HasValue()) return ReplaceNumber(FastUI2D(m.Value()));
       break;
     }
-    case IrOpcode::kLoadElement: {
-      ElementAccess access = ElementAccessOf(node->op());
-      if (access.bounds_check == kTypedArrayBoundsCheck) {
-        NumberMatcher mkey(node->InputAt(1));
-        NumberMatcher mlength(node->InputAt(2));
-        if (mkey.HasValue() && mlength.HasValue()) {
-          // Skip the typed array bounds check if key and length are constant.
-          if (mkey.Value() >= 0 && mkey.Value() < mlength.Value()) {
-            access.bounds_check = kNoBoundsCheck;
-            node->set_op(simplified()->LoadElement(access));
-            return Changed(node);
-          }
-        }
-      }
-      break;
-    }
-    case IrOpcode::kStoreElement: {
-      ElementAccess access = ElementAccessOf(node->op());
-      if (access.bounds_check == kTypedArrayBoundsCheck) {
-        NumberMatcher mkey(node->InputAt(1));
-        NumberMatcher mlength(node->InputAt(2));
-        if (mkey.HasValue() && mlength.HasValue()) {
-          // Skip the typed array bounds check if key and length are constant.
-          if (mkey.Value() >= 0 && mkey.Value() < mlength.Value()) {
-            access.bounds_check = kNoBoundsCheck;
-            node->set_op(simplified()->StoreElement(access));
-            return Changed(node);
-          }
-        }
-      }
-      break;
-    }
+    case IrOpcode::kBoundsCheck:
+      return ReduceBoundsCheck(node);
     default:
       break;
   }
   return NoChange();
 }
+
+
+namespace {
+
+// TODO(bmeurer): Move to node-matchers.h/cc
+class BoundsCheckMatcher FINAL : public NodeMatcher {
+ public:
+  typedef Uint32Matcher Offset;
+  typedef Uint32Matcher Length;
+
+  explicit BoundsCheckMatcher(Node* node)
+      : NodeMatcher(node), offset_(InputAt(0)), length_(InputAt(1)) {
+    DCHECK_EQ(IrOpcode::kBoundsCheck, opcode());
+  }
+
+  Offset const& offset() const { return offset_; }
+  Length const& length() const { return length_; }
+  size_t guard() const { return OpParameter<size_t>(op()); }
+
+ private:
+  Offset const offset_;
+  Length const length_;
+};
+
+}  // namespace
+
+
+Reduction SimplifiedOperatorReducer::ReduceBoundsCheck(Node* const node) {
+  BoundsCheckMatcher m(node);
+  if (m.offset().HasValue()) {
+    if (m.length().HasValue()) {
+      return Replace((m.offset().Value() < m.length().Value())
+                         ? m.offset().node()
+                         : m.length().node());
+    }
+    if (m.offset().Value() <= m.guard()) {
+      return Replace(m.offset().node());
+    }
+  }
+  if (m.offset().IsInt32Add()) {
+    Uint32BinopMatcher moffset(m.offset().node());
+    if (moffset.right().IsInRange(0, m.guard())) {
+      Node* const chk = graph()->NewNode(
+          simplified()->BoundsCheck(m.guard() - moffset.right().Value()),
+          moffset.left().node(), m.length().node());
+      Node* const add =
+          graph()->NewNode(machine()->Int32Add(), chk, moffset.right().node());
+      return Replace(add);
+    }
+  }
+  return NoChange();
+}
 
 
 Reduction SimplifiedOperatorReducer::Change(Node* node, const Operator* op,
                                             Node* a) {
   node->set_op(op);
   node->ReplaceInput(0, a);
   return Changed(node);
 }
 
 
@@ skipping 25 matching lines @@
 }
 
 
 MachineOperatorBuilder* SimplifiedOperatorReducer::machine() const {
   return jsgraph()->machine();
 }
 
 }  // namespace compiler
 }  // namespace internal
 }  // namespace v8