Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(220)

Issue 768513003: Fixed return value in error path -- result instead of false. (Closed)

Created:
6 years ago by brucedawson
Modified:
6 years ago
Reviewers:
grt (UTC plus 2)
CC:
chromium-reviews, robertshield
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fixed return value in error path -- result instead of false. Found by VC++'s /analyze. src\win8\test\ui_automation_client.cc(380) : warning C6216: Compiler-inserted cast between semantically different integral types: a Boolean type to HRESULT. BUG=427616 Committed: https://crrev.com/131645aa41fdbb736398a841902e779ed08390e8 Cr-Commit-Position: refs/heads/master@{#306753}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M win8/test/ui_automation_client.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
brucedawson
Minor bug in this test, found by VC++'s /analyze.
6 years ago (2014-12-04 01:40:14 UTC) #2
grt (UTC plus 2)
lgtm Nice! Thanks for the fix.
6 years ago (2014-12-04 02:10:32 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/768513003/1
6 years ago (2014-12-04 02:11:37 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years ago (2014-12-04 03:02:37 UTC) #6
commit-bot: I haz the power
6 years ago (2014-12-04 03:03:30 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/131645aa41fdbb736398a841902e779ed08390e8
Cr-Commit-Position: refs/heads/master@{#306753}

Powered by Google App Engine
This is Rietveld 408576698