Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1047)

Unified Diff: sky/engine/core/dom/Element.cpp

Issue 768493002: Get rid of CompositingState. (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: fix incorrect case. Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sky/engine/core/dom/Element.cpp
diff --git a/sky/engine/core/dom/Element.cpp b/sky/engine/core/dom/Element.cpp
index c08831d23bf64569456e2969e422315fcae1c745..07faae587f8de97610555c8dbf6b1770f2db0573 100644
--- a/sky/engine/core/dom/Element.cpp
+++ b/sky/engine/core/dom/Element.cpp
@@ -841,10 +841,6 @@ void Element::detach(const AttachContext& context)
if (ActiveAnimations* activeAnimations = data->activeAnimations()) {
if (context.performingReattach) {
- // FIXME: We call detach from within style recalc, so compositingState is not up to date.
- // https://code.google.com/p/chromium/issues/detail?id=339847
- DisableCompositingQueryAsserts disabler;
-
// FIXME: restart compositor animations rather than pull back to the main thread
activeAnimations->cancelAnimationOnCompositor();
} else {

Powered by Google App Engine
This is Rietveld 408576698