sky/engine/core/animation/Animation.cpp - Issue 768493002: Get rid of CompositingState.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sky/engine/core/animation/Animation.cpp

Issue 768493002: Get rid of CompositingState. (Closed) Base URL: git@github.com:domokit/mojo.git@master

Patch Set: fix incorrect case. Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sky/engine/core/animation/Animation.cpp

diff --git a/sky/engine/core/animation/Animation.cpp b/sky/engine/core/animation/Animation.cpp

index 32924be33d4d376d4179a94c0ceff3e59596486d..d7d3d15bb5adf0ae02baaf7bde903eee6d22c978 100644

--- a/sky/engine/core/animation/Animation.cpp

+++ b/sky/engine/core/animation/Animation.cpp

@@ -276,10 +276,6 @@ bool Animation::affects(CSSPropertyID property) const

void Animation::cancelAnimationOnCompositor()

{

- // FIXME: cancelAnimationOnCompositor is called from withins style recalc.

- // This queries compositingState, which is not necessarily up to date.

- // https://code.google.com/p/chromium/issues/detail?id=339847

- DisableCompositingQueryAsserts disabler;

if (!hasActiveAnimationsOnCompositor())

return;

if (!m_target || !m_target->renderer())