Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3438)

Unified Diff: chrome/browser/about_flags.cc

Issue 768413003: TEST ONLY - DO NOT SUBMIT - FOR TRYBOTS (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix bad merge Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/app/generated_resources.grd ('k') | chrome/browser/chromeos/login/ui/simple_web_view_dialog.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/about_flags.cc
diff --git a/chrome/browser/about_flags.cc b/chrome/browser/about_flags.cc
index 8c731a726a7f717de0d50022f3d3418d8386d811..a4b9eadb1f300ca1a133dda07128dcf89b2d024f 100644
--- a/chrome/browser/about_flags.cc
+++ b/chrome/browser/about_flags.cc
@@ -284,32 +284,6 @@ const Experiment::Choice kEnableGpuRasterizationChoices[] = {
switches::kForceGpuRasterization, "" },
};
-// We're using independent flags here (as opposed to a common flag with
-// different values) to be able to enable/disable the entire experience
-// associated with this feature server-side from the FieldTrial (the complete
-// experience includes other flag changes as well). It is not currently possible
-// to do that with "flag=value" flags.
-const Experiment::Choice kSearchButtonInOmniboxChoices[] = {
- { IDS_GENERIC_EXPERIMENT_CHOICE_DEFAULT, "", "" },
- { IDS_GENERIC_EXPERIMENT_CHOICE_DISABLED,
- switches::kDisableSearchButtonInOmnibox, ""},
- { IDS_FLAGS_SEARCH_BUTTON_IN_OMNIBOX_ENABLE_FOR_STR,
- switches::kEnableSearchButtonInOmniboxForStr, ""},
- { IDS_FLAGS_SEARCH_BUTTON_IN_OMNIBOX_ENABLE_FOR_STR_OR_IIP,
- switches::kEnableSearchButtonInOmniboxForStrOrIip, ""},
- { IDS_FLAGS_SEARCH_BUTTON_IN_OMNIBOX_ENABLED,
- switches::kEnableSearchButtonInOmniboxAlways, ""}
-};
-
-// See comment above for kSearchButtonInOmniboxChoices. The same reasoning
-// applies here.
-const Experiment::Choice kOriginChipChoices[] = {
- { IDS_GENERIC_EXPERIMENT_CHOICE_DEFAULT, "", "" },
- { IDS_GENERIC_EXPERIMENT_CHOICE_DISABLED, switches::kDisableOriginChip, ""},
- { IDS_FLAGS_ORIGIN_CHIP_ALWAYS, switches::kEnableOriginChipAlways, ""},
- { IDS_FLAGS_ORIGIN_CHIP_ON_SRP, switches::kEnableOriginChipOnSrp, ""}
-};
-
const Experiment::Choice kTouchScrollingModeChoices[] = {
{ IDS_GENERIC_EXPERIMENT_CHOICE_DEFAULT, "", "" },
{ IDS_FLAGS_TOUCH_SCROLLING_MODE_TOUCHCANCEL,
@@ -1647,20 +1621,6 @@ const Experiment kExperiments[] = {
MULTI_VALUE_TYPE(kNumRasterThreadsChoices)
},
{
- "origin-chip-in-omnibox",
- IDS_FLAGS_ORIGIN_CHIP_NAME,
- IDS_FLAGS_ORIGIN_CHIP_DESCRIPTION,
- kOsCrOS | kOsMac | kOsWin | kOsLinux,
- MULTI_VALUE_TYPE(kOriginChipChoices)
- },
- {
- "search-button-in-omnibox",
- IDS_FLAGS_SEARCH_BUTTON_IN_OMNIBOX_NAME,
- IDS_FLAGS_SEARCH_BUTTON_IN_OMNIBOX_DESCRIPTION,
- kOsCrOS | kOsMac | kOsWin | kOsLinux,
- MULTI_VALUE_TYPE(kSearchButtonInOmniboxChoices)
- },
- {
"ignore-autocomplete-off-autofill",
IDS_FLAGS_IGNORE_AUTOCOMPLETE_OFF_AUTOFILL_NAME,
IDS_FLAGS_IGNORE_AUTOCOMPLETE_OFF_AUTOFILL_DESCRIPTION,
« no previous file with comments | « chrome/app/generated_resources.grd ('k') | chrome/browser/chromeos/login/ui/simple_web_view_dialog.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698