Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4128)

Unified Diff: chrome/browser/background/background_contents_service.cc

Issue 768373002: Remove DesktopNotificationService::AddIconNotification. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/notifications/desktop_notification_service.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/background/background_contents_service.cc
diff --git a/chrome/browser/background/background_contents_service.cc b/chrome/browser/background/background_contents_service.cc
index 338a0768d9488af065e6f15dfb0e417a06a48ea9..8bae55001fa2aa6bffbfefade5e0a4f34a03d636 100644
--- a/chrome/browser/background/background_contents_service.cc
+++ b/chrome/browser/background/background_contents_service.cc
@@ -170,14 +170,15 @@ void NotificationImageReady(
// the same origin when NOTIFICATION_EXTENSION_UNLOADED_DEPRECATED.
// TODO(mukai, dewittj): remove this and switch to message center
// notifications.
Peter Beverloo 2014/12/02 16:13:41 Is this TODO still relevant? The NotificationUIMan
dewittj 2014/12/02 17:25:12 yeah, plz remove :)
Peter Beverloo 2014/12/03 15:50:39 Done.
- DesktopNotificationService::AddIconNotification(
- GURL("chrome://extension-crash"), // Origin URL.
- base::string16(), // Title of notification.
- message,
- notification_icon,
- base::UTF8ToUTF16(delegate->id()), // Replace ID.
- delegate.get(),
- profile);
+ Notification notification(GURL("chrome://extension-crash"),
+ base::string16(),
+ message,
+ notification_icon,
+ base::string16(),
+ base::UTF8ToUTF16(delegate->id()),
+ delegate.get());
+
+ g_browser_process->notification_ui_manager()->Add(notification, profile);
}
#endif
« no previous file with comments | « no previous file | chrome/browser/notifications/desktop_notification_service.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698