Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(380)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 768373002: Remove DesktopNotificationService::AddIconNotification. (Closed)

Created:
6 years ago by Peter Beverloo
Modified:
6 years ago
CC:
chromium-reviews, peter+watch_chromium.org, mlamouri+watch-notifications_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Remove DesktopNotificationService::AddIconNotification. There's only two call sites, which can easily talk to the Notification UI Manager directly. BUG= Committed: https://crrev.com/acf80d3636671a7bf05bb5991e53dd32bedf9c91 Cr-Commit-Position: refs/heads/master@{#306677}

Patch Set 1 #

Total comments: 3

Patch Set 2 : remove comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -51 lines) Patch
M chrome/browser/background/background_contents_service.cc View 1 1 chunk +9 lines, -10 lines 0 comments Download
M chrome/browser/notifications/desktop_notification_service.h View 1 chunk +0 lines, -9 lines 0 comments Download
M chrome/browser/notifications/desktop_notification_service.cc View 1 chunk +0 lines, -24 lines 0 comments Download
M chrome/browser/status_icons/desktop_notification_balloon.cc View 1 chunk +9 lines, -8 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
Peter Beverloo
https://codereview.chromium.org/768373002/diff/1/chrome/browser/background/background_contents_service.cc File chrome/browser/background/background_contents_service.cc (right): https://codereview.chromium.org/768373002/diff/1/chrome/browser/background/background_contents_service.cc#newcode172 chrome/browser/background/background_contents_service.cc:172: // notifications. Is this TODO still relevant? The NotificationUIManager ...
6 years ago (2014-12-02 16:13:41 UTC) #2
dewittj
lgtm https://codereview.chromium.org/768373002/diff/1/chrome/browser/background/background_contents_service.cc File chrome/browser/background/background_contents_service.cc (right): https://codereview.chromium.org/768373002/diff/1/chrome/browser/background/background_contents_service.cc#newcode172 chrome/browser/background/background_contents_service.cc:172: // notifications. On 2014/12/02 16:13:41, Peter Beverloo wrote: ...
6 years ago (2014-12-02 17:25:12 UTC) #3
Jun Mukai
lgtm
6 years ago (2014-12-02 21:46:24 UTC) #4
Peter Beverloo
+thestig for all the chrome/ stamps \o/. https://codereview.chromium.org/768373002/diff/1/chrome/browser/background/background_contents_service.cc File chrome/browser/background/background_contents_service.cc (right): https://codereview.chromium.org/768373002/diff/1/chrome/browser/background/background_contents_service.cc#newcode172 chrome/browser/background/background_contents_service.cc:172: // notifications. ...
6 years ago (2014-12-03 15:50:39 UTC) #6
Lei Zhang
lgtm
6 years ago (2014-12-03 20:51:02 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/768373002/20001
6 years ago (2014-12-03 20:51:29 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years ago (2014-12-03 21:23:08 UTC) #10
commit-bot: I haz the power
6 years ago (2014-12-03 21:23:45 UTC) #11
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/acf80d3636671a7bf05bb5991e53dd32bedf9c91
Cr-Commit-Position: refs/heads/master@{#306677}

Powered by Google App Engine
This is Rietveld 408576698