Issue 768303002: Revert of MIPS: Use weak cells in map checks in polymorphic ICs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 768303002: Revert of MIPS: Use weak cells in map checks in polymorphic ICs. (Closed)

Created:
6 years ago by Michael Achenbach

Modified:
6 years ago

Reviewers:
balazs.kilvady, dusmil.imgtec, danno, ulan, akos.palfi.imgtec, gergely.kis.imgtec, paul.l...

CC:
v8-dev

Base URL:
https://chromium.googlesource.com/v8/v8.git@master

Project:
v8

Visibility:
Public.

Revert of MIPS: Use weak cells in map checks in polymorphic ICs. (patchset #1 id:1 of https://codereview.chromium.org/767623003/) Reason for revert: Need to revert the ported CL: https://codereview.chromium.org/771033003/ Original issue's description: > MIPS: Use weak cells in map checks in polymorphic ICs. > > Port 45a36948e1bb0f02d395ecbcfe6306553898268b > > Fix typo in the mips ports. > > BUG= TBR=ulan@chromium.org,danno@chromium.org,akos.palfi@imgtec.com,balazs.kilvady@imgtec.com,gergely.kis@imgtec.com,dusan.milosavljevic@imgtec.com,paul.lind@imgtec.com NOTREECHECKS=true NOTRY=true BUG=

Created: 6 years ago

(Patch set is too large to download)

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	src/mips/macro-assembler-mips.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	src/mips64/macro-assembler-mips64.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 3 (0 generated)

Michael Achenbach

Created Revert of MIPS: Use weak cells in map checks in polymorphic ICs.

6 years ago (2014-12-02 08:15:21 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/768303002/1

6 years ago (2014-12-02 08:15:24 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1)