Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Issue 767913002: Revert of git_auto_svn.py: Rewrite http SVN URLs to https (Closed)

Created:
6 years ago by kjellander_chromium
Modified:
6 years ago
Reviewers:
agable, Michael Moss
CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, iannucci+depot_tools_chromium.org
Project:
tools
Visibility:
Public.

Description

Revert of git_auto_svn.py: Rewrite http SVN URLs to https (patchset #3 id:40001 of https://codereview.chromium.org/745473003/) Reason for revert: This actually makes the Git mirrors unusable for git svn, since there's a mismatch between the svn remote URL and the URLs of the git-svn-id footers in each Git commit (which confuses scripts like git_cl.py and makes uploading and committing CLs impossible). Original issue's description: > git_auto_svn.py: Rewrite http SVN URLs to https > > BUG=435091 > TESTED=Ran the following: > git clone https://chromium.googlesource.com/external/webrtc > cd webrtc > git auto-svn > cat .git/config > Verified the URL was using http before this patch, and https after applying it. > > R=agable@chromium.org, mmoss@chromium.org > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=293041 TBR=agable@chromium.org,mmoss@chromium.org NOTREECHECKS=true NOTRY=true BUG=435091 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=293148

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -5 lines) Patch
M git_auto_svn.py View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
kjellander_chromium
Created Revert of git_auto_svn.py: Rewrite http SVN URLs to https
6 years ago (2014-11-29 16:56:47 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/767913002/1
6 years ago (2014-11-29 16:57:37 UTC) #2
commit-bot: I haz the power
Presubmit check for 767913002-1 failed and returned exit status 1. Running presubmit commit checks ...
6 years ago (2014-11-29 16:59:41 UTC) #4
kjellander_chromium
6 years ago (2014-11-29 17:03:59 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 293148.

Powered by Google App Engine
This is Rietveld 408576698