Issue 767873006: Check XpFactory equality in DrawState

Issue 767873006: Check XpFactory equality in DrawState (Closed)

Created:
6 years ago by egdaniel

Modified:
6 years ago

Reviewers:
joshualitt, bsalomon

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@moveXPHeader

Project:
skia

Visibility:
Public.

Created: 6 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+66 lines, -2 lines)			Patch
M	include/gpu/GrXferProcessor.h	View	1	1 chunk	+43 lines, -0 lines	0 comments	Download
M	include/gpu/effects/GrPorterDuffXferProcessor.h	View		1 chunk	+6 lines, -2 lines	0 comments	Download
M	src/gpu/GrDrawState.cpp	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	src/gpu/GrProcessor.cpp	View	1	2 chunks	+8 lines, -0 lines	0 comments	Download
M	src/gpu/effects/GrPorterDuffXferProcessor.cpp	View	1 2	1 chunk	+5 lines, -0 lines	0 comments	Download

Total messages: 9 (4 generated)

bsalomon

lgtm, but I think we should call it classID(). Both for consistency with grprocessor and ...

6 years ago (2014-12-05 16:42:03 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/767873006/20001

6 years ago (2014-12-05 20:16:18 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/767873006/40001

6 years ago (2014-12-05 20:50:18 UTC) #8

commit-bot: I haz the power

6 years ago (2014-12-05 20:58:33 UTC) #9

Message was sent while issue was closed.

Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/915187b71d4068f21a15a1b8f4d919e1179d8b74