Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Issue 767743003: [turbofan] NodeMarker in ControlReducer. (Closed)

Created:
6 years ago by titzer
Modified:
6 years ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Project:
v8
Visibility:
Public.

Description

[turbofan] NodeMarker in ControlReducer. R=mstarzinger@chromium.org BUG=

Patch Set 1 #

Patch Set 2 : #

Total comments: 1

Patch Set 3 : #

Patch Set 4 : Use uint8_t. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -37 lines) Patch
M src/compiler/control-reducer.cc View 1 2 3 9 chunks +56 lines, -37 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
titzer
6 years ago (2014-11-28 15:50:31 UTC) #1
titzer
6 years ago (2014-12-01 10:34:25 UTC) #3
Benedikt Meurer
LGTM with nit. https://codereview.chromium.org/767743003/diff/20001/src/compiler/control-reducer.cc File src/compiler/control-reducer.cc (right): https://codereview.chromium.org/767743003/diff/20001/src/compiler/control-reducer.cc#newcode20 src/compiler/control-reducer.cc:20: class ReachabilityMarker : public NodeMarker<byte> { ...
6 years ago (2014-12-01 10:36:36 UTC) #4
titzer
On 2014/12/01 10:36:36, Benedikt Meurer wrote: > LGTM with nit. > > https://codereview.chromium.org/767743003/diff/20001/src/compiler/control-reducer.cc > File ...
6 years ago (2014-12-01 10:47:43 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/767743003/60001
6 years ago (2014-12-01 11:22:29 UTC) #7
commit-bot: I haz the power
6 years ago (2014-12-01 11:50:44 UTC) #8
Message was sent while issue was closed.
Committed patchset #4 (id:60001)

Powered by Google App Engine
This is Rietveld 408576698