Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(301)

Side by Side Diff: src/ic/arm/ic-compiler-arm.cc

Issue 767743002: Hydrogen code stubs for vector-based ICs. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Rebase. Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/ic/arm/ic-arm.cc ('k') | src/ic/arm/stub-cache-arm.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #if V8_TARGET_ARCH_ARM 7 #if V8_TARGET_ARCH_ARM
8 8
9 #include "src/ic/ic.h" 9 #include "src/ic/ic.h"
10 #include "src/ic/ic-compiler.h" 10 #include "src/ic/ic-compiler.h"
(...skipping 23 matching lines...) Expand all
34 34
35 Handle<Code> PropertyICCompiler::CompilePolymorphic(TypeHandleList* types, 35 Handle<Code> PropertyICCompiler::CompilePolymorphic(TypeHandleList* types,
36 CodeHandleList* handlers, 36 CodeHandleList* handlers,
37 Handle<Name> name, 37 Handle<Name> name,
38 Code::StubType type, 38 Code::StubType type,
39 IcCheckType check) { 39 IcCheckType check) {
40 Label miss; 40 Label miss;
41 41
42 if (check == PROPERTY && 42 if (check == PROPERTY &&
43 (kind() == Code::KEYED_LOAD_IC || kind() == Code::KEYED_STORE_IC)) { 43 (kind() == Code::KEYED_LOAD_IC || kind() == Code::KEYED_STORE_IC)) {
44 // In case we are compiling an IC for dictionary loads and stores, just 44 // In case we are compiling an IC for dictionary loads or stores, just
45 // check whether the name is unique. 45 // check whether the name is unique.
46 if (name.is_identical_to(isolate()->factory()->normal_ic_symbol())) { 46 if (name.is_identical_to(isolate()->factory()->normal_ic_symbol())) {
47 // Keyed loads with dictionaries shouldn't be here, they go generic.
48 // The DCHECK is to protect assumptions when --vector-ics is on.
49 DCHECK(kind() != Code::KEYED_LOAD_IC);
47 Register tmp = scratch1(); 50 Register tmp = scratch1();
48 __ JumpIfSmi(this->name(), &miss); 51 __ JumpIfSmi(this->name(), &miss);
49 __ ldr(tmp, FieldMemOperand(this->name(), HeapObject::kMapOffset)); 52 __ ldr(tmp, FieldMemOperand(this->name(), HeapObject::kMapOffset));
50 __ ldrb(tmp, FieldMemOperand(tmp, Map::kInstanceTypeOffset)); 53 __ ldrb(tmp, FieldMemOperand(tmp, Map::kInstanceTypeOffset));
51 __ JumpIfNotUniqueNameInstanceType(tmp, &miss); 54 __ JumpIfNotUniqueNameInstanceType(tmp, &miss);
52 } else { 55 } else {
53 __ cmp(this->name(), Operand(name)); 56 __ cmp(this->name(), Operand(name));
54 __ b(ne, &miss); 57 __ b(ne, &miss);
55 } 58 }
56 } 59 }
(...skipping 66 matching lines...) Expand 10 before | Expand all | Expand 10 after
123 // Return the generated code. 126 // Return the generated code.
124 return GetCode(kind(), Code::NORMAL, factory()->empty_string(), POLYMORPHIC); 127 return GetCode(kind(), Code::NORMAL, factory()->empty_string(), POLYMORPHIC);
125 } 128 }
126 129
127 130
128 #undef __ 131 #undef __
129 } 132 }
130 } // namespace v8::internal 133 } // namespace v8::internal
131 134
132 #endif // V8_TARGET_ARCH_ARM 135 #endif // V8_TARGET_ARCH_ARM
OLDNEW
« no previous file with comments | « src/ic/arm/ic-arm.cc ('k') | src/ic/arm/stub-cache-arm.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698