Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Issue 767733002: De-generify the GenericGraph. (Closed)

Created:
6 years ago by Michael Starzinger
Modified:
6 years ago
Reviewers:
titzer
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Project:
v8
Visibility:
Public.

Description

De-generify the GenericGraph. R=titzer@chromium.org

Patch Set 1 #

Patch Set 2 : Rip out moar! #

Patch Set 3 : Adapt build system. #

Patch Set 4 : Rebased. #

Patch Set 5 : Rebased again. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -77 lines) Patch
M BUILD.gn View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M src/compiler/generic-algorithm.h View 1 3 chunks +4 lines, -6 lines 0 comments Download
M src/compiler/generic-algorithm-inl.h View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M src/compiler/generic-graph.h View 1 1 chunk +0 lines, -53 lines 0 comments Download
M src/compiler/generic-node.h View 1 3 chunks +5 lines, -6 lines 0 comments Download
M src/compiler/generic-node-inl.h View 1 4 chunks +4 lines, -4 lines 0 comments Download
M src/compiler/graph.h View 1 2 3 4 3 chunks +17 lines, -1 line 0 comments Download
M src/compiler/graph.cc View 1 2 3 4 1 chunk +6 lines, -1 line 0 comments Download
M src/compiler/graph-builder.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M src/compiler/node.h View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M tools/gyp/v8.gyp View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
Michael Starzinger
6 years ago (2014-11-28 12:53:41 UTC) #1
titzer
On 2014/11/28 12:53:41, Michael Starzinger wrote: LGTM LGTM LGTM
6 years ago (2014-11-28 13:19:28 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/767733002/70001
6 years ago (2014-11-28 13:52:42 UTC) #4
commit-bot: I haz the power
6 years ago (2014-11-28 14:21:07 UTC) #5
Message was sent while issue was closed.
Committed patchset #5 (id:70001)

Powered by Google App Engine
This is Rietveld 408576698