Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Unified Diff: dart/tests/try/web/incremental_compilation_update_test.dart

Issue 767723002: Remove todo and add test progress status. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: dart/tests/try/web/incremental_compilation_update_test.dart
diff --git a/dart/tests/try/web/incremental_compilation_update_test.dart b/dart/tests/try/web/incremental_compilation_update_test.dart
index d9740398832cc4f004086a41cd9020883fd6607e..1777711dc1650ecde42f703d2ac9534399b9b0b6 100644
--- a/dart/tests/try/web/incremental_compilation_update_test.dart
+++ b/dart/tests/try/web/incremental_compilation_update_test.dart
@@ -1302,8 +1302,7 @@ main() {
const ProgramResult(
r"""
main() {
- // TODO(ahe): Use forEach(print) when closures are computed correctly.
ahe 2014/11/28 11:45:19 Forgot to remove this in 740273003.
- ['v2'].forEach((e) { print(e); });
+ ['v2'].forEach(print);
}
""",
const <String>['v2']),
@@ -1315,6 +1314,11 @@ void main() {
document.head.append(lineNumberStyle());
+ summary = new SpanElement();
+ document.body.append(new HeadingElement.h1()
+ ..appendText("Incremental compiler tests")
+ ..append(summary));
+
String query = window.location.search;
int skip = 0;
if (query != null && query.length > 1) {
@@ -1324,13 +1328,22 @@ void main() {
skip = int.parse(skipParam);
}
}
+ testCount += skip;
- return asyncTest(() => Future.forEach(tests.skip(skip), compileAndRun));
+ return asyncTest(() => Future.forEach(tests.skip(skip), compileAndRun)
+ .then(updateSummary));
}
+SpanElement summary;
+
int testCount = 1;
+void updateSummary(_) {
+ summary.text = " (${testCount - 1}/${tests.length})";
+}
+
Future compileAndRun(List<ProgramResult> programs) {
+ updateSummary(null);
var status = new DivElement();
document.body.append(status);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698