DoResolveRelative must not parse mailto schemes as path URLs.

DoResolveRelative must not parse mailto schemes as path URLs.

Currently DoResolveRelative perform a ParsePathURL on those
URLs, which have a valid base_parsed_authority.host. However,
hash-mark (#) is not interpreted for mailto schemes, which
result an incorrect parsing.

BUG=413569
Committed: https://crrev.com/1e2171c1d5c24b6738fce18f93a530664e265602
Cr-Commit-Position: refs/heads/master@{#306803}

[zherczeg, 2014-11-28 10:35:19]

zherczeg.u-szeged@partner.samsung.com changed reviewers:
+ abarth@chromium.org, brettw@chromium.org

[zherczeg, 2014-12-01 13:27:24]

On 2014/11/28 10:35:19, zherczeg wrote:

Please review this.

[brettw, 2014-12-01 20:15:10]

https://codereview.chromium.org/767713002/diff/1/url/url_util.cc
File url/url_util.cc (right):

https://codereview.chromium.org/767713002/diff/1/url/url_util.cc#newcode242
url/url_util.cc:242: ResolveRelativeURL(base_spec, base_parsed_authority, false,
relative,
This should write into your temporary buffer rather than you copying out of it
and then filling it back in.

https://codereview.chromium.org/767713002/diff/1/url/url_util_unittest.cc
File url/url_util_unittest.cc (right):

https://codereview.chromium.org/767713002/diff/1/url/url_util_unittest.cc#new...
url/url_util_unittest.cc:299: // The following address has
base_parsed_authority.host, but
base_parsed_authority has no meaning in this context. Can you write this comment
in such a way that you don't need to understand all the code to know what's
being tested?

[zherczeg, 2014-12-02 08:58:23]

I fixed your requests.

[brettw, 2014-12-03 23:34:06]

lgtm

[zherczeg, 2014-12-04 09:56:17]

The CQ bit was checked by zherczeg.u-szeged@partner.samsung.com

[commit-bot: I haz the power, 2014-12-04 09:57:14]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/767713002/20001

[commit-bot: I haz the power, 2014-12-04 11:52:43]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2014-12-04 11:53:27]

Patchset 2 (id:??) landed as
https://crrev.com/1e2171c1d5c24b6738fce18f93a530664e265602
Cr-Commit-Position: refs/heads/master@{#306803}