Source/web/WebViewImpl.cpp - Issue 767693002: [POC] copying video frame

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/WebViewImpl.cpp

Issue 767693002: [POC] copying video frame Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/web/WebViewImpl.cpp

diff --git a/Source/web/WebViewImpl.cpp b/Source/web/WebViewImpl.cpp

index ed2ee8b3a4c8627ed0eeaef94c608fae31e8030c..970114a21646dd807a527f5dd65d9e5db8adb042 100644

--- a/Source/web/WebViewImpl.cpp

+++ b/Source/web/WebViewImpl.cpp

@@ -3476,7 +3476,8 @@ void WebViewImpl::copyImageAt(const WebPoint& point)

Node* node = result.innerNonSharedNode();

ASSERT(node);

- if (!isHTMLCanvasElement(*node) && result.absoluteImageURL().isEmpty()) {

+ if (!isHTMLCanvasElement(*node) && result.absoluteImageURL().isEmpty()

+ && !isHTMLVideoElement(*node)) {

// There isn't actually an image at these coordinates. Might be because

// the window scrolled while the context menu was open or because the page

// changed itself between when we thought there was an image here and when

« no previous file with comments | « Source/core/editing/Editor.cpp ('k') | no next file » | no next file with comments »