Braille improvements in contenteditables.

Braille improvements in contenteditables.

This fixes two issues with editing text using braille in contenteditable
elements:
- Non-breaking spaces in the element confused the detection of changes that
  weren't caused by the braille IME causing grade 2 braille input to be
  interrupted inside words.    is now normalized to normal spaces
  for the purpose of braille output in this case.

- Blank lines weren't shown because of a special case handling for tts output.
  Now braille is included in that special case.

BUG=392854
Committed: https://crrev.com/eb7b406d7a1f3428dd900543f17e82fe0c4aeb6a
Cr-Commit-Position: refs/heads/master@{#307010}

[Peter Lundblad, 2014-12-04 16:23:50]

plundblad@chromium.org changed reviewers:
+ dtseng@chromium.org

[David Tseng, 2014-12-04 22:53:26]

LGTM

https://codereview.chromium.org/767683003/diff/1/chrome/browser/resources/chr...
File chrome/browser/resources/chromeos/chromevox/common/editable_text.js
(right):

https://codereview.chromium.org/767683003/diff/1/chrome/browser/resources/chr...
chrome/browser/resources/chromeos/chromevox/common/editable_text.js:395: if
(this instanceof cvox.ChromeVoxEditableContentEditable) {
Does this belong in the subclass (i.e. replace value on |evt|/normalize evt
itself)?

https://codereview.chromium.org/767683003/diff/1/chrome/browser/resources/chr...
chrome/browser/resources/chromeos/chromevox/common/editable_text.js:401:
console.log('Changed: ' + line + ' ' + start + ' ' + end + ' ' + lineStart);
Remove.

[Peter Lundblad, 2014-12-05 10:17:18]

The CQ bit was checked by plundblad@chromium.org

[commit-bot: I haz the power, 2014-12-05 10:17:59]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/767683003/20001

[Peter Lundblad, 2014-12-05 10:25:13]

dtseng@chromium.org writes:
> LGTM
> 
> 
> 
>
https://codereview.chromium.org/767683003/diff/1/chrome/browser/resources/chr...
> File chrome/browser/resources/chromeos/chromevox/common/editable_text.js
> (right):
> 
>
https://codereview.chromium.org/767683003/diff/1/chrome/browser/resources/chr...
> chrome/browser/resources/chromeos/chromevox/common/editable_text.js:395:
> if (this instanceof cvox.ChromeVoxEditableContentEditable) {
> Does this belong in the subclass (i.e. replace value on |evt|/normalize
> evt itself)?

Normalizing in the event would affect speech as well. Maybe that's fine.
Right now, we say nothing when landing on an nbsp.  Do you feel we want to
distinguish them in speech?
I leave this as is for now and commit, happy to move it to validate for both
speech and braille.

>
https://codereview.chromium.org/767683003/diff/1/chrome/browser/resources/chr...
> chrome/browser/resources/chromeos/chromevox/common/editable_text.js:401:
> console.log('Changed: ' + line + ' ' + start + ' ' + end + ' ' +
> lineStart);
> Remove.

Yeah... Done.

> https://codereview.chromium.org/767683003/

-- 

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[commit-bot: I haz the power, 2014-12-05 10:50:56]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2014-12-05 10:51:43]

Patchset 2 (id:??) landed as
https://crrev.com/eb7b406d7a1f3428dd900543f17e82fe0c4aeb6a
Cr-Commit-Position: refs/heads/master@{#307010}