De-generalize create_typeface on Windows.

De-generalize create_typeface on Windows.

The gdi and dw backends have a local create_typeface function.
This function is now called in only one place, onLegacyCreateTypeface.
Move the implementation into the caller.

R=caryclark@google.com

Committed: https://code.google.com/p/skia/source/detail?r=12313

[caryclark, 2013-11-19 21:56:39]

https://codereview.chromium.org/76763002/diff/1/src/ports/SkFontHost_win_dw.cpp
File src/ports/SkFontHost_win_dw.cpp (right):

https://codereview.chromium.org/76763002/diff/1/src/ports/SkFontHost_win_dw.c...
src/ports/SkFontHost_win_dw.cpp:1838: hr = get_by_family_name(familyName,
&fontFamily);
if 'hr' is always effectively discarded, would

  (void) get_by_family_name(

serve as well? As is, I keep scanning to see if hr is ever checked.

https://codereview.chromium.org/76763002/diff/1/src/ports/SkFontHost_win_dw.c...
src/ports/SkFontHost_win_dw.cpp:1844: hr = get_default_font(&font);
I see that 'font' here is not the same as 'font' below, but I'd feel better if
the two variables didn't share the same name.

[bungeman-skia, 2013-11-19 22:27:34]

Now with more error checking and less conflicting names.

https://codereview.chromium.org/76763002/diff/1/src/ports/SkFontHost_win_dw.cpp
File src/ports/SkFontHost_win_dw.cpp (right):

https://codereview.chromium.org/76763002/diff/1/src/ports/SkFontHost_win_dw.c...
src/ports/SkFontHost_win_dw.cpp:1838: hr = get_by_family_name(familyName,
&fontFamily);
On 2013/11/19 21:56:39, caryclark wrote:
> if 'hr' is always effectively discarded, would
> 
>   (void) get_by_family_name(
> 
> serve as well? As is, I keep scanning to see if hr is ever checked.

Yes, well, it's here because it's a big red flag that error checking hasn't
actually been thought about yet. If I remember correctly, this call wasn't
allowed to ever return NULL, but that was difficult. I believe this is now
allowed to return NULL if all sorts of things fail, so I will update
appropriately.

https://codereview.chromium.org/76763002/diff/1/src/ports/SkFontHost_win_dw.c...
src/ports/SkFontHost_win_dw.cpp:1844: hr = get_default_font(&font);
On 2013/11/19 21:56:39, caryclark wrote:
> I see that 'font' here is not the same as 'font' below, but I'd feel better if
> the two variables didn't share the same name.

Done. Yes, this is a bit confusing, renamed this one to defaultFont.

[caryclark, 2013-11-20 13:15:56]

much nicer. Thanks for cleaning this up. lgtm

[bungeman-skia, 2013-11-20 15:11:08]

Committed patchset #2 manually as r12313 (presubmit successful).