Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(584)

Issue 767623003: MIPS: Use weak cells in map checks in polymorphic ICs. (Closed)

Created:
6 years ago by paul.l...
Modified:
6 years ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Project:
v8
Visibility:
Public.

Description

MIPS: Use weak cells in map checks in polymorphic ICs. Port 45a36948e1bb0f02d395ecbcfe6306553898268b Fix typo in the mips ports. BUG=

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M src/mips/macro-assembler-mips.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/mips64/macro-assembler-mips64.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
paul.l...
PTAL.
6 years ago (2014-12-01 21:27:39 UTC) #2
akos.palfi.imgtec
LGTM.
6 years ago (2014-12-01 21:57:03 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/767623003/1
6 years ago (2014-12-01 21:58:38 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years ago (2014-12-01 22:26:44 UTC) #6
Michael Achenbach
6 years ago (2014-12-02 08:15:21 UTC) #7
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/768303002/ by machenbach@chromium.org.

The reason for reverting is: Need to revert the ported CL:
https://codereview.chromium.org/771033003/.

Powered by Google App Engine
This is Rietveld 408576698