Issue 7676002: When deleting storage through the cookies tree model, also update its cache

Issue 7676002: When deleting storage through the cookies tree model, also update its cache (Closed)

Created:
9 years, 4 months ago by jochen (gone - plz use gerrit)

Modified:
9 years, 4 months ago

Reviewers:
Bernhard Bauer, commit-bot: I haz the power

CC:
chromium-reviews, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

When deleting storage through the cookies tree model, also update its cache BUG=43249 TEST=CookiesTreeModelTest.RemoveAll Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=97245

Patch Set 3 : updates #

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+311 lines, -244 lines)			Patch
M	chrome/browser/browsing_data_database_helper.h	View		5 chunks	+6 lines, -6 lines	0 comments	Download
M	chrome/browser/browsing_data_database_helper.cc	View		4 chunks	+4 lines, -4 lines	0 comments	Download
M	chrome/browser/browsing_data_database_helper_browsertest.cc	View		3 chunks	+16 lines, -12 lines	0 comments	Download
M	chrome/browser/browsing_data_file_system_helper.h	View		5 chunks	+7 lines, -7 lines	0 comments	Download
M	chrome/browser/browsing_data_file_system_helper.cc	View		5 chunks	+6 lines, -6 lines	0 comments	Download
M	chrome/browser/browsing_data_file_system_helper_unittest.cc	View	1	6 chunks	+41 lines, -37 lines	0 comments	Download
M	chrome/browser/browsing_data_helper_browsertest.h	View		3 chunks	+4 lines, -4 lines	0 comments	Download
M	chrome/browser/browsing_data_indexed_db_helper.h	View		4 chunks	+6 lines, -6 lines	0 comments	Download
M	chrome/browser/browsing_data_indexed_db_helper.cc	View		6 chunks	+7 lines, -7 lines	0 comments	Download
M	chrome/browser/browsing_data_indexed_db_helper_browsertest.cc	View		2 chunks	+9 lines, -5 lines	0 comments	Download
M	chrome/browser/browsing_data_local_storage_helper.h	View		5 chunks	+5 lines, -5 lines	0 comments	Download
M	chrome/browser/browsing_data_local_storage_helper.cc	View		3 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/browsing_data_local_storage_helper_browsertest.cc	View		3 chunks	+17 lines, -11 lines	0 comments	Download
M	chrome/browser/browsing_data_quota_helper.h	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/browsing_data_quota_helper_impl.h	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/browsing_data_quota_helper_impl.cc	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/cookies_tree_model.h	View	1 2	16 chunks	+74 lines, -60 lines	0 comments	Download
M	chrome/browser/cookies_tree_model.cc	View	1 2	24 chunks	+74 lines, -41 lines	0 comments	Download
M	chrome/browser/cookies_tree_model_unittest.cc	View	1 2	1 chunk	+4 lines, -0 lines	0 comments	Download
M	chrome/browser/mock_browsing_data_database_helper.h	View		2 chunks	+5 lines, -5 lines	0 comments	Download
M	chrome/browser/mock_browsing_data_database_helper.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/mock_browsing_data_file_system_helper.h	View		2 chunks	+5 lines, -5 lines	0 comments	Download
M	chrome/browser/mock_browsing_data_file_system_helper.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/mock_browsing_data_indexed_db_helper.h	View		3 chunks	+5 lines, -5 lines	0 comments	Download
M	chrome/browser/mock_browsing_data_indexed_db_helper.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/mock_browsing_data_local_storage_helper.h	View		3 chunks	+5 lines, -5 lines	0 comments	Download
M	chrome/browser/mock_browsing_data_local_storage_helper.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/mock_browsing_data_quota_helper.h	View		2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Bernhard Bauer

LGTM w/ nits: http://codereview.chromium.org/7676002/diff/2001/chrome/browser/cookies_tree_model.cc File chrome/browser/cookies_tree_model.cc (right): http://codereview.chromium.org/7676002/diff/2001/chrome/browser/cookies_tree_model.cc#newcode66 chrome/browser/cookies_tree_model.cc:66: // data is not problematic as ...

9 years, 4 months ago (2011-08-17 13:34:36 UTC) #2

Change committed as 97245

Expand Messages | Collapse Messages