Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(349)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 767593002: Handle interpolation of SVG <paint> 'currentColor' w/ Web/CSS Animations (Closed)

Created:
6 years ago by fs
Modified:
6 years ago
Reviewers:
dstockwell, Timothy Loh
CC:
blink-reviews, shans, rjwright, Mike Lawther (Google), blink-reviews-animation_chromium.org, dstockwell, darktears, Steve Block, Eric Willigers
Project:
blink
Visibility:
Public.

Description

Handle interpolation of SVG <paint> 'currentColor' w/ Web/CSS Animations Normalize 'currentColor' to <rgbcolor>, and then interpolate that. This is similar to how color properties work wrt 'currentColor'. 'currentColor' as a fallback is still left as non-interpolated. BUG=436772 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=186406

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+83 lines, -2 lines) Patch
M LayoutTests/animations/interpolation/svg-fill-interpolation.html View 2 chunks +21 lines, -0 lines 0 comments Download
M LayoutTests/animations/interpolation/svg-fill-interpolation-expected.txt View 2 chunks +16 lines, -0 lines 0 comments Download
M LayoutTests/animations/interpolation/svg-stroke-interpolation.html View 2 chunks +21 lines, -0 lines 0 comments Download
M LayoutTests/animations/interpolation/svg-stroke-interpolation-expected.txt View 2 chunks +16 lines, -0 lines 0 comments Download
M Source/core/animation/css/CSSAnimatableValueFactory.cpp View 3 chunks +9 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
fs
6 years ago (2014-11-27 15:58:43 UTC) #2
fs
Ping?
6 years ago (2014-12-02 12:04:14 UTC) #3
Timothy Loh
On 2014/12/02 12:04:14, fs wrote: > Ping? lgtm, sorry for the high latency
6 years ago (2014-12-02 22:30:14 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/767593002/1
6 years ago (2014-12-03 10:32:41 UTC) #6
commit-bot: I haz the power
6 years ago (2014-12-03 10:35:40 UTC) #7
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=186406

Powered by Google App Engine
This is Rietveld 408576698