Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 767453003: [Android] Fix a subtle issue in Java Bridge regarding interfaces removal (Closed)

Created:
6 years ago by mnaganov (inactive)
Modified:
6 years ago
Reviewers:
benm (inactive)
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[Android] Fix a subtle issue in Java Bridge regarding interfaces removal Update JavaBridgeBasicsTest.testRemovalNotReflectedUntilReload to actually call Java GC after removing the interface, and verify that the Java object is still callable from the page side. Fix the code to make the test pass. BUG=437761 Committed: https://crrev.com/4d4182c4af0a11a1ad5acae88f9abe2b76853fe1 Cr-Commit-Position: refs/heads/master@{#306176}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -13 lines) Patch
M content/browser/android/java/gin_java_bridge_dispatcher_host.cc View 1 chunk +4 lines, -12 lines 0 comments Download
M content/public/android/javatests/src/org/chromium/content/browser/JavaBridgeBasicsTest.java View 1 chunk +13 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
mnaganov (inactive)
Ben, PTAL! I've noticed the issue while working on the background thread bug.
6 years ago (2014-12-01 10:59:51 UTC) #2
benm (inactive)
lgtm
6 years ago (2014-12-01 11:08:03 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/767453003/1
6 years ago (2014-12-01 11:09:31 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years ago (2014-12-01 11:59:21 UTC) #6
commit-bot: I haz the power
6 years ago (2014-12-01 12:00:02 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4d4182c4af0a11a1ad5acae88f9abe2b76853fe1
Cr-Commit-Position: refs/heads/master@{#306176}

Powered by Google App Engine
This is Rietveld 408576698