components/autofill/content/common/autofill_messages.h - Issue 767353002: Support for password manager suggestions on password fields.

Unified Diff: components/autofill/content/common/autofill_messages.h

Issue 767353002: Support for password manager suggestions on password fields. (Closed) Base URL: https://chromium.googlesource.com/chromium/src@master

Patch Set: Address gcasto's comments Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/autofill/autofill_popup_controller_impl.cc ('K') | « chrome/renderer/autofill/password_autofill_agent_browsertest.cc ('k') | components/autofill/content/renderer/password_autofill_agent.cc » ('j') | components/autofill/core/common/autofill_constants.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/autofill/content/common/autofill_messages.h

diff --git a/components/autofill/content/common/autofill_messages.h b/components/autofill/content/common/autofill_messages.h

index cd5cd1ed997d21daf075910b4996c368499f8b5e..1933c760164a19c41252a9713f791a9751ce19f7 100644

--- a/components/autofill/content/common/autofill_messages.h

+++ b/components/autofill/content/common/autofill_messages.h

@@ -10,6 +10,7 @@

#include "base/strings/string16.h"

#include "base/time/time.h"

#include "components/autofill/content/common/autofill_param_traits_macros.h"

+#include "components/autofill/core/common/autofill_constants.h"

#include "components/autofill/core/common/form_data.h"

#include "components/autofill/core/common/form_data_predictions.h"

#include "components/autofill/core/common/form_field_data.h"

@@ -291,12 +292,13 @@ IPC_MESSAGE_ROUTED0(AutofillHostMsg_HidePasswordGenerationPopup)

// Instruct the browser to show a popup with suggestions filled from data

// associated with |key|. The popup will use |text_direction| for displaying

// text.

-IPC_MESSAGE_ROUTED5(AutofillHostMsg_ShowPasswordSuggestions,

- int /* key */,

- base::i18n::TextDirection /*text_direction */,

- base::string16 /* username typed by user */,

- bool /* show all suggestions */,

- gfx::RectF /* input field bounds, window-relative */)

+IPC_MESSAGE_ROUTED5(

+ AutofillHostMsg_ShowPasswordSuggestions,

+ int /* key */,

+ base::i18n::TextDirection /*text_direction */,

+ base::string16 /* username typed by user */,

+ int /* show all suggestions and the field is a password field options */,

Evan Stade 2014/12/03 17:54:50 This comment isn't very clear. "options bitmask"

Tom Sepez 2014/12/03 18:17:09 nit: Maybe its an enum (if its not a bitmask).

jww 2014/12/04 18:59:56 Changed to "options bitmask of autofill::ShowPassw

+ gfx::RectF /* input field bounds, window-relative */)

// Inform browser of data list values for the curent field.

IPC_MESSAGE_ROUTED2(AutofillHostMsg_SetDataList,