tests/PDFJpegEmbedTest.cpp - Issue 767343002: Remove PDF JPEG shortcut, since it fails on grayscale JPEGs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tests/PDFJpegEmbedTest.cpp

Issue 767343002: Remove PDF JPEG shortcut, since it fails on grayscale JPEGs. (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: disable unit test Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tests/PDFJpegEmbedTest.cpp

diff --git a/tests/PDFJpegEmbedTest.cpp b/tests/PDFJpegEmbedTest.cpp

index c1d0ea8452dbe448c8dc0ad4089eb2556cefa465..422b59a18f03ff8b87107e5cc85d8f6b17517bf6 100644

--- a/tests/PDFJpegEmbedTest.cpp

+++ b/tests/PDFJpegEmbedTest.cpp

@@ -84,7 +84,8 @@ DEF_TEST(PDFJpegEmbedTest, r) {

SkASSERT(pdfData);

pdf.reset();

- REPORTER_ASSERT(r, is_subset_of(mandrillData, pdfData));

+ // Test disabled, waiting on resolution to http://skbug.com/3180

+ // REPORTER_ASSERT(r, is_subset_of(mandrillData, pdfData));

// This JPEG uses a nonstandard colorspace - it can not be

// embedded into the PDF directly.

« no previous file with comments | « src/pdf/SkPDFImage.cpp ('k') | no next file » | no next file with comments »