tests/PictureBBHTest.cpp - Issue 767333002: Defer saves() until they're needed

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tests/PictureBBHTest.cpp

Issue 767333002: Defer saves() until they're needed (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: now with faster counter Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tests/PictureBBHTest.cpp

diff --git a/tests/PictureBBHTest.cpp b/tests/PictureBBHTest.cpp

index bc712f575ec74faf998f62194548c44f32434c1c..562d9b59913026fc66e41c0e92b63b862085819b 100644

--- a/tests/PictureBBHTest.cpp

+++ b/tests/PictureBBHTest.cpp

@@ -119,7 +119,8 @@ static void test_clear(skiatest::Reporter* r, SkBBHFactory* factory) {

// Should be Clip - Save - Clear - Restore.

// Buggy implementations might return 1 (just Clip) or 3 (Clip - Save - Restore).

robertphillips 2014/12/11 13:24:36 Yes.

- REPORTER_ASSERT(r, dstPic->approximateOpCount() == 4);

+ // TODO: can we just search that it contains "clear"? <reed>

+ REPORTER_ASSERT(r, dstPic->approximateOpCount() == 4 || dstPic->approximateOpCount() == 2);

}

DEF_TEST(PictureBBH_Clear, r) {