services/js/js_app_runner_delegate.cc - Issue 767323002: Mojo JS Bindings: restore the ServiceProvider class, add an application test

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: services/js/js_app_runner_delegate.cc

Issue 767323002: Mojo JS Bindings: restore the ServiceProvider class, add an application test (Closed) Base URL: https://github.com/domokit/mojo.git@master

Patch Set: Removed console import from ServiceProvider Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: services/js/js_app_runner_delegate.cc

diff --git a/services/js/js_app_runner_delegate.cc b/services/js/js_app_runner_delegate.cc

index 4036e8cc66d07249e96f6f3706f27803947cc35e..999bc6305cac3cb45f361bf0ba1c992c5969fe43 100644

--- a/services/js/js_app_runner_delegate.cc

+++ b/services/js/js_app_runner_delegate.cc

@@ -29,9 +29,9 @@ std::vector<base::FilePath> GetModuleSearchPaths() {

JSAppRunnerDelegate::JSAppRunnerDelegate()

: ModuleRunnerDelegate(GetModuleSearchPaths()) {

AddBuiltinModule(gin::Console::kModuleName, gin::Console::GetModule);

- AddBuiltinModule(js::Core::kModuleName, js::Core::GetModule);

- AddBuiltinModule(js::Support::kModuleName, js::Support::GetModule);

- AddBuiltinModule(js::Threading::kModuleName, js::Threading::GetModule);

+ AddBuiltinModule(Core::kModuleName, Core::GetModule);

+ AddBuiltinModule(Support::kModuleName, Support::GetModule);

+ AddBuiltinModule(Threading::kModuleName, Threading::GetModule);

}

JSAppRunnerDelegate::~JSAppRunnerDelegate() {

« no previous file with comments | « services/js/js_app_bridge_module.cc ('k') | services/js/js_apptests.cc » ('j') | no next file with comments »