Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Unified Diff: services/js/js_app_bridge_module.cc

Issue 767323002: Mojo JS Bindings: restore the ServiceProvider class, add an application test (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Removed console import from ServiceProvider Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « services/js/js_app_bridge_module.h ('k') | services/js/js_app_runner_delegate.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: services/js/js_app_bridge_module.cc
diff --git a/services/js/mojo_bridge_module.cc b/services/js/js_app_bridge_module.cc
similarity index 80%
rename from services/js/mojo_bridge_module.cc
rename to services/js/js_app_bridge_module.cc
index de9b2457ce33f9f7eff3f094e7127555ab52b8d5..1b1e70c7cc17409ac0e12e98cef60c7331868dcf 100644
--- a/services/js/mojo_bridge_module.cc
+++ b/services/js/js_app_bridge_module.cc
@@ -2,7 +2,7 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#include "services/js/mojo_bridge_module.h"
+#include "services/js/js_app_bridge_module.h"
#include "gin/arguments.h"
#include "gin/converter.h"
@@ -20,10 +20,9 @@ gin::WrapperInfo g_wrapper_info = {gin::kEmbedderNativeGin};
} // namespace
-const char MojoInternals::kModuleName[] = "services/js/bridge";
+const char AppBridge::kModuleName[] = "services/js/app-bridge";
-v8::Local<v8::Value> MojoInternals::GetModule(JSApp* js_app,
- v8::Isolate* isolate) {
+v8::Local<v8::Value> AppBridge::GetModule(JSApp* js_app, v8::Isolate* isolate) {
gin::PerIsolateData* data = gin::PerIsolateData::From(isolate);
v8::Local<v8::ObjectTemplate> templ =
data->GetObjectTemplate(&g_wrapper_info);
« no previous file with comments | « services/js/js_app_bridge_module.h ('k') | services/js/js_app_runner_delegate.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698