Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1244)

Unified Diff: Source/core/rendering/RenderObject.h

Issue 767283005: Take continuation into consideration when calculating absoluteClippedOverflowRect. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/rendering/RenderObject.h
diff --git a/Source/core/rendering/RenderObject.h b/Source/core/rendering/RenderObject.h
index 91dc4f0ef784e45710543f4112b1e86ffe768666..1cdcb922a2b516ac981d6dd1725d720589afa154 100644
--- a/Source/core/rendering/RenderObject.h
+++ b/Source/core/rendering/RenderObject.h
@@ -861,7 +861,7 @@ public:
// Returns the rect that should have paint invalidated whenever this object changes. The rect is in the view's
// coordinate space. This method deals with outlines and overflow.
- LayoutRect absoluteClippedOverflowRect() const;
+ virtual LayoutRect absoluteClippedOverflowRect() const;
pdr. 2014/12/02 21:56:21 Can you just update RenderInline::clippedOverflowR
c.shu 2014/12/02 22:16:31 I put the code in absoluteClippedOverflowRect for
pdr. 2014/12/03 22:11:17 Remember that making a function virtual pretty muc
c.shu 2014/12/03 22:27:27 There are only a few callers, 1. hasOffscreenRect
virtual LayoutRect clippedOverflowRectForPaintInvalidation(const RenderLayerModelObject* paintInvalidationContainer, const PaintInvalidationState* = 0) const;
virtual LayoutRect rectWithOutlineForPaintInvalidation(const RenderLayerModelObject* paintInvalidationContainer, LayoutUnit outlineWidth, const PaintInvalidationState* = 0) const;
« Source/core/rendering/RenderInline.cpp ('K') | « Source/core/rendering/RenderInline.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698