Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(157)

Side by Side Diff: Source/core/rendering/RenderInline.h

Issue 767283005: Take continuation into consideration when calculating absoluteClippedOverflowRect. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009 Apple Inc. All rights reserved. 4 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009 Apple Inc. All rights reserved.
5 * 5 *
6 * This library is free software; you can redistribute it and/or 6 * This library is free software; you can redistribute it and/or
7 * modify it under the terms of the GNU Library General Public 7 * modify it under the terms of the GNU Library General Public
8 * License as published by the Free Software Foundation; either 8 * License as published by the Free Software Foundation; either
9 * version 2 of the License, or (at your option) any later version. 9 * version 2 of the License, or (at your option) any later version.
10 * 10 *
(...skipping 78 matching lines...) Expand 10 before | Expand all | Expand 10 after
89 using RenderBoxModelObject::continuation; 89 using RenderBoxModelObject::continuation;
90 using RenderBoxModelObject::setContinuation; 90 using RenderBoxModelObject::setContinuation;
91 91
92 bool alwaysCreateLineBoxes() const { return alwaysCreateLineBoxesForRenderIn line(); } 92 bool alwaysCreateLineBoxes() const { return alwaysCreateLineBoxesForRenderIn line(); }
93 void setAlwaysCreateLineBoxes(bool alwaysCreateLineBoxes = true) { setAlways CreateLineBoxesForRenderInline(alwaysCreateLineBoxes); } 93 void setAlwaysCreateLineBoxes(bool alwaysCreateLineBoxes = true) { setAlways CreateLineBoxesForRenderInline(alwaysCreateLineBoxes); }
94 void updateAlwaysCreateLineBoxes(bool fullLayout); 94 void updateAlwaysCreateLineBoxes(bool fullLayout);
95 95
96 virtual LayoutRect localCaretRect(InlineBox*, int, LayoutUnit* extraWidthToE ndOfLine) override final; 96 virtual LayoutRect localCaretRect(InlineBox*, int, LayoutUnit* extraWidthToE ndOfLine) override final;
97 97
98 bool hitTestCulledInline(const HitTestRequest&, HitTestResult&, const HitTes tLocation& locationInContainer, const LayoutPoint& accumulatedOffset); 98 bool hitTestCulledInline(const HitTestRequest&, HitTestResult&, const HitTes tLocation& locationInContainer, const LayoutPoint& accumulatedOffset);
99 LayoutRect absoluteClippedOverflowRect() const override;
pdr. 2014/12/02 21:56:21 Should this be virtual? Also final?
c.shu 2014/12/02 22:16:31 sounds good. thanks.
99 100
100 protected: 101 protected:
101 virtual void willBeDestroyed() override; 102 virtual void willBeDestroyed() override;
102 103
103 virtual void styleDidChange(StyleDifference, const RenderStyle* oldStyle) ov erride; 104 virtual void styleDidChange(StyleDifference, const RenderStyle* oldStyle) ov erride;
104 105
105 virtual void computeSelfHitTestRects(Vector<LayoutRect>& rects, const Layout Point& layerOffset) const override; 106 virtual void computeSelfHitTestRects(Vector<LayoutRect>& rects, const Layout Point& layerOffset) const override;
106 107
107 private: 108 private:
108 virtual RenderObjectChildList* virtualChildren() override final { return chi ldren(); } 109 virtual RenderObjectChildList* virtualChildren() override final { return chi ldren(); }
(...skipping 72 matching lines...) Expand 10 before | Expand all | Expand 10 after
181 182
182 RenderObjectChildList m_children; 183 RenderObjectChildList m_children;
183 RenderLineBoxList m_lineBoxes; // All of the line boxes created for this i nline flow. For example, <i>Hello<br>world.</i> will have two <i> line boxes. 184 RenderLineBoxList m_lineBoxes; // All of the line boxes created for this i nline flow. For example, <i>Hello<br>world.</i> will have two <i> line boxes.
184 }; 185 };
185 186
186 DEFINE_RENDER_OBJECT_TYPE_CASTS(RenderInline, isRenderInline()); 187 DEFINE_RENDER_OBJECT_TYPE_CASTS(RenderInline, isRenderInline());
187 188
188 } // namespace blink 189 } // namespace blink
189 190
190 #endif // RenderInline_h 191 #endif // RenderInline_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698