src/heap/gc-idle-time-handler.cc - Issue 767233003: Perform smaller marking steps incrementally in idle notification.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/heap/gc-idle-time-handler.cc

Issue 767233003: Perform smaller marking steps incrementally in idle notification. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/heap/gc-idle-time-handler.cc

diff --git a/src/heap/gc-idle-time-handler.cc b/src/heap/gc-idle-time-handler.cc

index 92fb5530ef57acb1e5e8650a93ee914c1ed4b3f7..cbcdfa407f22e6d1cb72396e3d1685d48c8e0564 100644

--- a/src/heap/gc-idle-time-handler.cc

+++ b/src/heap/gc-idle-time-handler.cc

@@ -250,7 +250,7 @@ GCIdleTimeAction GCIdleTimeHandler::Compute(double idle_time_in_ms,

return GCIdleTimeAction::Nothing();

}

size_t step_size = EstimateMarkingStepSize(

- static_cast<size_t>(idle_time_in_ms),

+ static_cast<size_t>(kIncrementalMarkingStepTimeInMs),

heap_state.incremental_marking_speed_in_bytes_per_ms);

return GCIdleTimeAction::IncrementalMarking(step_size);

}

« no previous file with comments | « src/heap/gc-idle-time-handler.h ('k') | src/heap/heap.cc » ('j') | src/heap/heap.cc » ('J')