Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(246)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 767233003: Perform smaller marking steps incrementally in idle notification. (Closed)

Created:
6 years ago by Hannes Payer (out of office)
Modified:
6 years ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Project:
v8
Visibility:
Public.

Description

Perform smaller marking steps incrementally in idle notification. BUG=

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -8 lines) Patch
M src/heap/gc-idle-time-handler.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/heap/gc-idle-time-handler.cc View 1 2 chunks +3 lines, -2 lines 0 comments Download
M src/heap/heap.cc View 1 2 1 chunk +12 lines, -6 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
jochen (gone - plz use gerrit)
lgtm https://codereview.chromium.org/767233003/diff/1/src/heap/heap.cc File src/heap/heap.cc (right): https://codereview.chromium.org/767233003/diff/1/src/heap/heap.cc#newcode4500 src/heap/heap.cc:4500: } while (remaining_idle_time_in_ms >= 2 && maybe 2.0 ...
6 years ago (2014-12-02 10:30:31 UTC) #2
Hannes Payer (out of office)
https://codereview.chromium.org/767233003/diff/1/src/heap/heap.cc File src/heap/heap.cc (right): https://codereview.chromium.org/767233003/diff/1/src/heap/heap.cc#newcode4500 src/heap/heap.cc:4500: } while (remaining_idle_time_in_ms >= 2 && On 2014/12/02 10:30:31, ...
6 years ago (2014-12-02 10:37:54 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/767233003/40001
6 years ago (2014-12-02 10:38:05 UTC) #7
commit-bot: I haz the power
6 years ago (2014-12-02 11:25:02 UTC) #8
Message was sent while issue was closed. 
Committed patchset #3 (id:40001)

Powered by Google App Engine
This is Rietveld 408576698