Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(720)

Unified Diff: runtime/vm/profiler_android.cc

Issue 76723003: Fix Android build ? (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | runtime/vm/signal_handler_android.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/profiler_android.cc
diff --git a/runtime/vm/profiler_android.cc b/runtime/vm/profiler_android.cc
index c10c59987d5566754f1418c975f7077f4e2f7f6f..d8d67472851a6e6a086409c12d9e60f26e1b2f9e 100644
--- a/runtime/vm/profiler_android.cc
+++ b/runtime/vm/profiler_android.cc
@@ -14,25 +14,11 @@ namespace dart {
DECLARE_FLAG(bool, profile);
-static void CollectSample(IsolateProfilerData* profiler_data,
- uintptr_t pc,
- uintptr_t fp,
- uintptr_t sp,
- uintptr_t stack_lower,
- uintptr_t stack_upper) {
- SampleBuffer* sample_buffer = profiler_data->sample_buffer();
- Sample* sample = sample_buffer->ReserveSample();
- ASSERT(sample != NULL);
- sample->timestamp = OS::GetCurrentTimeMicros();
-}
-
static void ProfileSignalAction(int signal, siginfo_t* info, void* context_) {
if (signal != SIGPROF) {
return;
}
- ucontext_t* context = reinterpret_cast<ucontext_t*>(context_);
- mcontext_t mcontext = context->uc_mcontext;
Isolate* isolate = Isolate::Current();
if (isolate == NULL) {
return;
@@ -45,15 +31,6 @@ static void ProfileSignalAction(int signal, siginfo_t* info, void* context_) {
if (profiler_data == NULL) {
return;
}
- uintptr_t stack_lower = 0;
- uintptr_t stack_upper = 0;
- isolate->GetStackBounds(&stack_lower, &stack_upper);
- uintptr_t PC = SignalHandler::GetProgramCounter(mcontext);
- uintptr_t FP = SignalHandler::GetFramePointer(mcontext);
- uintptr_t SP = SignalHandler::GetStackPointer(mcontext);
- int64_t sample_time = OS::GetCurrentTimeMicros();
- profiler_data->SampledAt(sample_time);
- CollectSample(profiler_data, PC, FP, SP, stack_lower, stack_upper);
}
// Thread owns no profiler locks at this point.
// This call will acquire both ProfilerManager::monitor and the
« no previous file with comments | « no previous file | runtime/vm/signal_handler_android.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698