Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Issue 76723002: Land Recent QUIC Changes. (Closed)

Created:
7 years, 1 month ago by ramant (doing other things)
Modified:
7 years, 1 month ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org, dcheng
Visibility:
Public.

Description

Land Recent QUIC Changes. Make QuicTestClient report response_complete() when the response is actually complete. Merge internal change: 56678980 Remove retransmission_count from RetransmissionInfo, because it was unused. Merge internal change: 56678610 Deprecating FLAGS_bundle_ack_with_outgoing_packet. Removes a QUIC-specific flag that has been set to true for a while. Merge internal change: 56673783 Remove unnecessary tests from QuicEpollConnectionHelperTests since much of the logic that used to be in the helper has moved directly into the connection. Merge internal change: 56613436 Ensure that delta_time_largest_observed values are non-negative, since they are written to the wire as uints. Provide a better estimate of rtt in QUIC. Merge internal change: 56612513 Change QUIC's max CWND from a flag to a constant. Merge internal change: 56607206 Make SimpleClient report whether headers have been completely received. Testing only. This brings simpleclient to feature parity for ustreamer load testing. Merge internal change: 56543369 QUIC - Sync'ing changes while merging chromium/internal changes. Merge internal change: 56537661 Remove deprecated flag FLAGS_track_retransmission_history. Merge internal change: 56530712 Change PacketDroppingTestWriter::WritePacket to release any packets that should have already been released. Merge internal change: 56496423 Add the QUIC detailed error to the ConnectionClose packet for framing errors. Merge internal change: 56478281 Resurrect QUIC fast-RTO tail drop behavior. More quickly RTO packets if there are only a few packets outstanding. Merge internal change: 56476598 Remove EndToEndTest.NoEarlyHeadersFailureFromClient. This test races a retransmission with a RST_STREAM in a way that is not guaranteed to win. Further, it purports to send a valid request, but when the reset loses the race, it's clear that actually the request is actually not valid. Instead, I've replaced this test with a unit test of QuicSession and in the process tightened up the code to detect QUIC_STREAM_RST_BEFORE_HEADERS_DECOMPRESSED. Improved the ability of QuicSession to detect unrecoverable compression context state. Merge internal change: 56472103 Cleanup WriteBlockedList. * Sanity check the values of priorities passed in to various methods. * Cleanup of the argument types used. * Change GetHighestPriorityWriteBlockedList to not return -1, which is confusing since the priority value is (usually) unsigned. Merge internal change: 56467687 Changes to support internal QuicFasterStatsGatherer class which inherits from QuicAckNotifier::DelegateInterface and FasterStatsGatherer. Each QuicStream owns one of these Gatherers. Whenever the Stream writes data to the wire, it registers the Gatherer to be notified on receipt of ACKs for the write. When the Gatherer has seen ACKs for the full response, it calculates Response Time (RT), and ships off the stats to FasterStats. If the QuicStream is destroyed before the full response has been ACKed, then it transfers ownership of the Gatherer to the QuicSession. The FasterStatsIdleList will check in periodically on these stored Gatherers, and when the full response has been ACKed, the Gatherer will ship off FasterStats and be deleted. Calculate FasterStats RT for QUIC. Merge internal change: 56407485 Add a method to QUIC end-to-end-test's TestParams struct so that when a test fails, the summary includes a human readable description of the configuration. Merge internal change: 56382748 Replace QUIC EndToEndTest.InvalidPriority with a unit tests. The existing end-to-end test is very fragile, and depending the behavior of the sender, may actually crash. Minor change to QUIC priority parsing error detection. Merge internal change: 56375355 R=rch@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=236173

Patch Set 1 #

Patch Set 2 : Fix compilation error #

Unified diffs Side-by-side diffs Delta from patch set Stats (+671 lines, -666 lines) Patch
M net/quic/congestion_control/quic_congestion_manager.h View 3 chunks +4 lines, -4 lines 0 comments Download
M net/quic/congestion_control/quic_congestion_manager.cc View 6 chunks +23 lines, -17 lines 0 comments Download
M net/quic/congestion_control/quic_congestion_manager_test.cc View 4 chunks +78 lines, -8 lines 0 comments Download
M net/quic/congestion_control/send_algorithm_interface.cc View 1 chunk +1 line, -2 lines 0 comments Download
M net/quic/quic_connection.cc View 6 chunks +9 lines, -7 lines 0 comments Download
M net/quic/quic_connection_helper_test.cc View 3 chunks +2 lines, -2 lines 0 comments Download
M net/quic/quic_connection_test.cc View 115 chunks +135 lines, -178 lines 0 comments Download
M net/quic/quic_framer.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M net/quic/quic_protocol.h View 1 chunk +4 lines, -0 lines 0 comments Download
M net/quic/quic_received_packet_manager.cc View 2 chunks +15 lines, -8 lines 0 comments Download
M net/quic/quic_received_packet_manager_test.cc View 1 chunk +20 lines, -0 lines 0 comments Download
M net/quic/quic_reliable_client_stream_test.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M net/quic/quic_sent_packet_manager.h View 4 chunks +14 lines, -27 lines 0 comments Download
M net/quic/quic_sent_packet_manager.cc View 12 chunks +47 lines, -60 lines 0 comments Download
M net/quic/quic_sent_packet_manager_test.cc View 1 13 chunks +16 lines, -46 lines 0 comments Download
M net/quic/quic_session.h View 1 chunk +10 lines, -5 lines 0 comments Download
M net/quic/quic_session.cc View 3 chunks +15 lines, -8 lines 0 comments Download
M net/quic/quic_session_test.cc View 1 chunk +18 lines, -0 lines 0 comments Download
M net/quic/reliable_quic_stream.h View 2 chunks +8 lines, -3 lines 0 comments Download
M net/quic/reliable_quic_stream.cc View 3 chunks +9 lines, -7 lines 0 comments Download
M net/quic/reliable_quic_stream_test.cc View 10 chunks +29 lines, -17 lines 0 comments Download
M net/quic/test_tools/quic_connection_peer.h View 1 chunk +2 lines, -3 lines 0 comments Download
M net/quic/test_tools/quic_connection_peer.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M net/quic/test_tools/quic_test_utils.h View 3 chunks +11 lines, -5 lines 0 comments Download
M net/quic/test_tools/quic_test_utils.cc View 2 chunks +13 lines, -1 line 0 comments Download
M net/spdy/write_blocked_list.h View 4 chunks +37 lines, -17 lines 0 comments Download
M net/spdy/write_blocked_list_test.cc View 2 chunks +6 lines, -7 lines 0 comments Download
M net/tools/quic/end_to_end_test.cc View 3 chunks +11 lines, -1 line 0 comments Download
M net/tools/quic/quic_epoll_connection_helper_test.cc View 1 chunk +65 lines, -194 lines 0 comments Download
M net/tools/quic/quic_reliable_server_stream_test.cc View 6 chunks +14 lines, -12 lines 0 comments Download
M net/tools/quic/quic_server_session_test.cc View 4 chunks +0 lines, -16 lines 0 comments Download
M net/tools/quic/test_tools/packet_dropping_test_writer.h View 2 chunks +7 lines, -2 lines 0 comments Download
M net/tools/quic/test_tools/packet_dropping_test_writer.cc View 3 chunks +14 lines, -1 line 0 comments Download
M net/tools/quic/test_tools/quic_test_client.h View 3 chunks +5 lines, -2 lines 0 comments Download
M net/tools/quic/test_tools/quic_test_client.cc View 3 chunks +20 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
ramant (doing other things)
7 years, 1 month ago (2013-11-19 20:55:53 UTC) #1
Ryan Hamilton
lgtm lgtm since i have reviewed all the individual changes.
7 years, 1 month ago (2013-11-19 20:59:12 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rtenneti@chromium.org/76723002/1
7 years, 1 month ago (2013-11-19 21:07:07 UTC) #3
commit-bot: I haz the power
Failed to trigger a try job on win_x64_rel HTTP Error 400: Bad Request
7 years, 1 month ago (2013-11-19 22:25:20 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rtenneti@chromium.org/76723002/280001
7 years, 1 month ago (2013-11-19 22:27:51 UTC) #5
commit-bot: I haz the power
7 years, 1 month ago (2013-11-20 05:56:02 UTC) #6
Message was sent while issue was closed.
Change committed as 236173

Powered by Google App Engine
This is Rietveld 408576698