Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Issue 767183002: ARIA state/property aria-pressed is not exposed(Blink). (Closed)

Created:
6 years ago by shreeramk
Modified:
6 years ago
Reviewers:
dmazzoni
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

ARIA state/property aria-pressed is not exposed(Blink). According to specs http://rawgit.com/w3c/aria/master/core-aam/core-aam.html aria-pressed {true, mixed} should set STATE_SYSTEM_PRESSED and false should clear STATE_SYSTEM_PRESSED HTML: <div tabindex=0 role="button">Regular button</div> <div tabindex=1 role="button" aria-pressed="false">Toggle button unpressed</div> <div tabindex=2 role="button" aria-pressed="true">Toggle button pressed</div> <div tabindex=3 role="button" aria-pressed="mixed">Toggle button mixed</div> AX Tree ROLE_SYSTEM_PUSHBUTTON FOCUSABLE IA2_ROLE_TOGGLE_BUTTON FOCUSABLE checkable:true IA2_ROLE_TOGGLE_BUTTON PRESSED FOCUSABLE checkable:true IA2_ROLE_TOGGLE_BUTTON PRESSED FOCUSABLE checkable:true BUG=171625 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=186789

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M Source/modules/accessibility/AXNodeObject.cpp View 1 chunk +4 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
shreeramk
Please review. Thanks!!
6 years ago (2014-12-01 10:29:06 UTC) #2
shreeramk
On 2014/12/01 10:29:06, shreeramk wrote: > Please review. > > Thanks!! @Dmazzoni: Could you please ...
6 years ago (2014-12-05 04:52:16 UTC) #3
shreeramk
@Dominic: Please take a look. Thanks!!
6 years ago (2014-12-08 19:37:30 UTC) #4
dmazzoni
lgtm
6 years ago (2014-12-09 17:03:32 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/767183002/1
6 years ago (2014-12-09 17:03:58 UTC) #7
commit-bot: I haz the power
6 years ago (2014-12-09 17:42:08 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=186789

Powered by Google App Engine
This is Rietveld 408576698