Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(298)

Issue 767083006: Move remaining test targets out of //mojo/public. (Closed)

Created:
6 years ago by blundell
Modified:
6 years ago
Reviewers:
jamesr
CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@move_mojo_sdk_test_targets
Project:
mojo
Visibility:
Public.

Description

Move remaining test targets out of //mojo/public. The test targets currently in //mojo/public depend on the EDK to run and thus are not part of the public SDK. This CL converts the remaining test targets in the public SDK into testonly mojo_sdk_source_sets, and adds new test targets under the EDK that depend on the corresponding source_sets as well as the EDK mechanism for running the unittests. Note that the dependencies from the test targets to the source_sets are specified via relative paths as part of the work toward having the EDK be flexible wrt its location in a client repo. BUG=439082

Patch Set 1 #

Patch Set 2 : Nit #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -25 lines) Patch
M mojo/BUILD.gn View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/edk/mojo_edk_tests.gyp View 1 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/edk/test/BUILD.gn View 4 chunks +20 lines, -4 lines 0 comments Download
M mojo/public/cpp/system/tests/BUILD.gn View 1 chunk +14 lines, -9 lines 0 comments Download
M mojo/public/cpp/utility/tests/BUILD.gn View 1 chunk +13 lines, -8 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
blundell
6 years ago (2014-12-09 07:59:09 UTC) #2
blundell
friendly ping
6 years ago (2014-12-10 22:51:51 UTC) #3
blundell
qsr@ is going to take charge of this while I'm out.
6 years ago (2014-12-12 17:17:45 UTC) #4
jamesr
The gyp changes and comments don't apply any more, but otherwise lgtm
6 years ago (2014-12-13 01:36:30 UTC) #5
qsr
6 years ago (2014-12-15 09:12:51 UTC) #6
On 2014/12/13 01:36:30, jamesr wrote:
> The gyp changes and comments don't apply any more, but otherwise lgtm

Removed gyp comments. Moved the CL to:
https://codereview.chromium.org/796853003/

Powered by Google App Engine
This is Rietveld 408576698