Media Galleries API Metadata: Make Blob native extension bindings available to multiple extensions.

Media Galleries API Metadata: Make Blob native extension bindings available to multiple extensions.

Feedback_private currently has a extension native handler for getting a Blob's UUID. Media Galleries API Metadata and other extensions that take a Blob will also want this.

This simply moves the function from a Feedback_private specific custom binding to a general ObjectBackedNativeHandler called BlobNativeHandler. This follows the CssNativeHandler example.

The parent class changed from ChromeV8Extension to ObjectBackedNativeHandler because ChromeV8Extension class has been deprecated.

R=thestig@chromium.org

BUG=318450
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=236847

[tommycli, 2013-11-19 20:31:05]

rkc: Any objections to making your Blob UUID native handler available to other
extensions?

[Lei Zhang, 2013-11-19 21:28:41]

couple nits

https://codereview.chromium.org/76703002/diff/1/chrome/renderer/extensions/bl...
File chrome/renderer/extensions/blob_native_handler.cc (right):

https://codereview.chromium.org/76703002/diff/1/chrome/renderer/extensions/bl...
chrome/renderer/extensions/blob_native_handler.cc:22: DCHECK(args.Length() ==
1);
DCHECK_EQ

https://codereview.chromium.org/76703002/diff/1/chrome/renderer/extensions/bl...
File chrome/renderer/extensions/blob_native_handler.h (right):

https://codereview.chromium.org/76703002/diff/1/chrome/renderer/extensions/bl...
chrome/renderer/extensions/blob_native_handler.h:18: void GetBlobUuid(const
v8::FunctionCallbackInfo<v8::Value> &args);
nit: ">& args);"

[tommycli, 2013-11-19 22:16:05]

https://codereview.chromium.org/76703002/diff/1/chrome/renderer/extensions/bl...
File chrome/renderer/extensions/blob_native_handler.cc (right):

https://codereview.chromium.org/76703002/diff/1/chrome/renderer/extensions/bl...
chrome/renderer/extensions/blob_native_handler.cc:22: DCHECK(args.Length() ==
1);
On 2013/11/19 21:28:41, Lei Zhang wrote:
> DCHECK_EQ

Done.

https://codereview.chromium.org/76703002/diff/1/chrome/renderer/extensions/bl...
File chrome/renderer/extensions/blob_native_handler.h (right):

https://codereview.chromium.org/76703002/diff/1/chrome/renderer/extensions/bl...
chrome/renderer/extensions/blob_native_handler.h:18: void GetBlobUuid(const
v8::FunctionCallbackInfo<v8::Value> &args);
On 2013/11/19 21:28:41, Lei Zhang wrote:
> nit: ">& args);"

Done.

[tommycli, 2013-11-21 18:08:30]

rkc: Ping

[rkc, 2013-11-21 21:46:34]

lgtm

Keep in mind though that this code was implemented as a hack. Currently the
blobs sent via this method aren't ref-counted, so the app sending these blobs
need to make sure that they keep a reference around till the API is done reading
them in Chrome.

[tommycli, 2013-11-21 22:29:35]

thestig: Need OWNER review.

[tommycli, 2013-11-22 18:53:15]

thestig: I restructured the cc file to be the same as before. I added some
additional commentary from rkc to the .h file.

[Lei Zhang, 2013-11-22 20:10:57]

lgtm

[commit-bot: I haz the power, 2013-11-22 20:22:55]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tommycli@chromium.org/76703002/270001

[commit-bot: I haz the power, 2013-11-22 22:30:17]

Change committed as 236847