Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(563)

Issue 767013007: [Chromoting] Share code that updates the UI when clientSession changes. (Closed)

Created:
6 years ago by garykac
Modified:
6 years ago
Reviewers:
Jamie
CC:
chromium-reviews, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[Chromoting] Share code that updates the UI when clientSession changes. This moves the duplicated code into a shared function and adds checks to ensure the UI element exists before calling setClientSession on it. NOTRY=True BUG= Committed: https://crrev.com/b3352ce8ec00ec703fd5531ed282fe7f3674467b Cr-Commit-Position: refs/heads/master@{#306741}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -15 lines) Patch
M remoting/webapp/crd/js/client_session.js View 3 chunks +25 lines, -15 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
garykac
6 years ago (2014-12-03 01:49:30 UTC) #2
Jamie
lgtm
6 years ago (2014-12-04 01:44:04 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/767013007/1
6 years ago (2014-12-04 01:49:55 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years ago (2014-12-04 01:50:33 UTC) #6
commit-bot: I haz the power
6 years ago (2014-12-04 01:51:24 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b3352ce8ec00ec703fd5531ed282fe7f3674467b
Cr-Commit-Position: refs/heads/master@{#306741}

Powered by Google App Engine
This is Rietveld 408576698