Issue 7670026: Fix continuous and official builds.

Issue 7670026: Fix continuous and official builds. (Closed)

Created:
9 years, 4 months ago by Sigurður Ásgeirsson

Modified:
9 years, 4 months ago

Reviewers:
Roger McFarlane (Chromium), M-A Ruel

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/tools/build/

Visibility:
Public.

Description

Fix continuous and official builds. Fix typo in continuous builder setup that caused them not to trigger on changes. Add a category property to official builder. Make the archiving store the achive to a path ending in filename.zip. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=97136

Patch Set 1 #

Total comments: 4

Patch Set 2 : Remove decoy defaults #

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -3 lines)			Patch
M	masters/master.client.syzygy/master_win_cont_cfg.py	View		1 chunk	+1 line, -1 line	0 comments	Download
M	masters/master.client.syzygy/master_win_official_cfg.py	View	1	2 chunks	+1 line, -1 line	0 comments	Download
M	scripts/master/factory/syzygy_commands.py	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Roger McFarlane (Chromium)

lgtm http://codereview.chromium.org/7670026/diff/1/masters/master.client.syzygy/master_win_cont_cfg.py File masters/master.client.syzygy/master_win_cont_cfg.py (right): http://codereview.chromium.org/7670026/diff/1/masters/master.client.syzygy/master_win_cont_cfg.py#newcode8 masters/master.client.syzygy/master_win_cont_cfg.py:8: defaults = { 'category': 'continuous' } Doh! http://codereview.chromium.org/7670026/diff/1/masters/master.client.syzygy/master_win_official_cfg.py ...

9 years, 4 months ago (2011-08-17 14:59:49 UTC) #2

Sigurður Ásgeirsson

Thanks, M-A, can I have your owner's blessing? http://codereview.chromium.org/7670026/diff/1/masters/master.client.syzygy/master_win_cont_cfg.py File masters/master.client.syzygy/master_win_cont_cfg.py (right): http://codereview.chromium.org/7670026/diff/1/masters/master.client.syzygy/master_win_cont_cfg.py#newcode8 masters/master.client.syzygy/master_win_cont_cfg.py:8: defaults ...

9 years, 4 months ago (2011-08-17 15:08:13 UTC) #4

lgtm

Expand Messages | Collapse Messages